Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp41736pxj; Wed, 16 Jun 2021 19:45:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzivRTBM1sgTQDxM0Wmptz0GcbPdllkKbJk43fRRhRUzAoKSi5IVbPp/ObbxRP1SB1oJZpx X-Received: by 2002:a17:906:3d9:: with SMTP id c25mr2669097eja.63.1623897903915; Wed, 16 Jun 2021 19:45:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623897903; cv=none; d=google.com; s=arc-20160816; b=NmLfMbQLMpvrzgitbddJG0CRbvrFA9ISDQm7+d2eSVl6rwbE0fiIH34oppR1MyUN5a muTGJT0OYIAJ0QSfTiTiqxCTdXT9Le5MeAYc0oheJucD1o1VLwgtTwvB72PrDYByOYq0 NA8BLORxcjKFbJFTy3o2jodVyGGOk3qaZ1ZmfsYecWsdrrDaSOeuSa2HFJ4gA3Iny53w iW1Rk8yygkVwA/UbFrTO21MMVT6jGRZEF+UOafQ1N0rjo5lZDHNQEHvGQsexWJhIMvqX 0x49Zi1XgHlfhwhEraXbSd/ELppfqa0sor3EZjQHljDo11ylNIsnzEmo+Aady0dowBg4 Kd9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=9t2jTHGA1c/Jjx7wR/JrOPa5SgqeftgcQuzAG+xf6xE=; b=BB+I5BEijB3udMIX4BjPUZ4XOx+Bz16Q6wohesz8yH6dCKg9PkJ4oNsVRLTNGOD5Bw bKYoXP50omZCWhb6y8pBvw13rVo445+rRErYZl4VPpE1dhIlCYXxxesYjaw3YT9/6h5B 8XDclv1ORwqbruRuEemNrRK3CQmYDLoGjg79aQhxgJ9e6ldJdSwpJm8OA3J+eiuKVx3f U2vVfBCdmi3dDmQnj55KTpefX1VxbSc102eEL3NNr4pGJGiBgMdRM7TbeXjx8ljXmeXP Kpfm8uQVj24GCxMLSLMIoPImCkp6xiOOOKP2lI+g+a7G76d9Zxr9rZ6GhNzDzTKuCcK1 KYBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si4112683ejy.157.2021.06.16.19.44.32; Wed, 16 Jun 2021 19:45:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231899AbhFQBRt (ORCPT + 99 others); Wed, 16 Jun 2021 21:17:49 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:43357 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231920AbhFQBRs (ORCPT ); Wed, 16 Jun 2021 21:17:48 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15H1FbjR031347 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Jun 2021 21:15:37 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id D49AD15C3CB8; Wed, 16 Jun 2021 21:15:36 -0400 (EDT) Date: Wed, 16 Jun 2021 21:15:36 -0400 From: "Theodore Ts'o" To: Pavel Skripkin Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+d9e482e303930fa4f6ff@syzkaller.appspotmail.com Subject: Re: [PATCH v2] ext4: fix memory leak in ext4_fill_super Message-ID: References: <20210430185046.15742-1-paskripkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210430185046.15742-1-paskripkin@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Apr 30, 2021 at 09:50:46PM +0300, Pavel Skripkin wrote: > static int kthread(void *_create) will return -ENOMEM > or -EINTR in case of internal failure or > kthread_stop() call happens before threadfn call. > > To prevent fancy error checking and make code > more straightforward we moved all cleanup code out > of kmmpd threadfn. > > Also, dropped struct mmpd_data at all. Now struct super_block > is a threadfn data and struct buffer_head embedded into > struct ext4_sb_info. > > Reported-by: syzbot+d9e482e303930fa4f6ff@syzkaller.appspotmail.com > Signed-off-by: Pavel Skripkin Applied, thanks! (And apologies for the delay) - Ted