Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp256416pxj; Thu, 17 Jun 2021 01:54:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoQUfdlR/ekPe+ysH7AlqdIErAeKnoom6098hxZqfqU7vTOd0AgKQ0aFVLtlvUXNmB4Ygg X-Received: by 2002:a05:6e02:d51:: with SMTP id h17mr2713003ilj.177.1623920078733; Thu, 17 Jun 2021 01:54:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623920078; cv=none; d=google.com; s=arc-20160816; b=g0OOqE0wUr7jULdjpskPmvigz50xZCqx6CoxMmmdMsUh3kbIOlPpQ9aCOkMGi1Zjlk ZOUuXVKCZC9R2PV3FvfkLjmQgLNacv7FjBhSYPTJ/A4ypzWtujpXD/36MjfVyvppEqxy HViiIGNFWM+18kEWUcAVNUgyUAdm872dVOul6aOHC1hdD5VGWXjaolMl3bJbhBRaZrsp xpBk2ZSD/3x/DraeSy8dd90k3DRn9ji0wjlZTJvOOe5WQre9ir5f7hbwDx58Cj20zGJX EnRvx3uiAG1PpPzwODMZFEdDFrvu/XYD02eccLjx/gEy4I79j21gdljlqD7l2ZgFMg8L SipA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=AqMZ6VDXQs8fACSxjEoTa3jWnXqlOeaX0ILKp41Ujpg=; b=VvVT+Jo+dfBmKI7a2RNesa17WiQP2at3sZmineBT6YvKytrAwCgenmy0QhNOJuyixo zwxQuBhWDIblUo0AJBxa0CJcu69k/YKUuDimygvnUreV6Kf7klnpyxEfojVQK6tX8OHh rfVKr1kSrqbShiLTMV4R5BMCpdPojDiqUuI/bvWZ6Irchi+pzXh80jXNTgarjFrxUVy4 f6vcjgEsqaUBp7tYlIakrLFLk6TRC8BM8t7zdHP5tFKp3ganNwWCXzQGerp6BM+QN1+Q KDTJ656GyIpMA2Lnhp0iq+NnyzAh/w2u6cd3DQvVWCNrsbMd+HCs7w7SSTImT1oNZqZs bzbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=vt+nizqa; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i17si3787470ilk.46.2021.06.17.01.54.22; Thu, 17 Jun 2021 01:54:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=vt+nizqa; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231203AbhFQIzb (ORCPT + 99 others); Thu, 17 Jun 2021 04:55:31 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:38750 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230312AbhFQIza (ORCPT ); Thu, 17 Jun 2021 04:55:30 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D1E741FDBF; Thu, 17 Jun 2021 08:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623920001; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AqMZ6VDXQs8fACSxjEoTa3jWnXqlOeaX0ILKp41Ujpg=; b=vt+nizqaqNppg74ojCy5P9EV49Hx8U+2xEiapBW704yiHrbUGgs/d6MGdqxK3PVg/GkS/e RmLG2VCA7qqBsKJQ7MGYHGTGsmziJNs06z1QldT/CEjXmHCCf36WDqS67BmefBDMgvjlUV srhgdjuc1NB9pzfw/X19pQ/TcfLcXeQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623920001; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AqMZ6VDXQs8fACSxjEoTa3jWnXqlOeaX0ILKp41Ujpg=; b=wNcM/bzZp+S6rae1Cjx+blaWgX6JIc/huCvNunJbz5gnULci61sK6dgac/Q02qOuAkVL3e V86JObPs0j//SiDQ== Received: from quack2.suse.cz (unknown [10.100.200.198]) by relay2.suse.de (Postfix) with ESMTP id 17E65A3BB7; Thu, 17 Jun 2021 08:53:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id E611F1F2C64; Thu, 17 Jun 2021 10:53:19 +0200 (CEST) Date: Thu, 17 Jun 2021 10:53:19 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , linux-fsdevel@vger.kernel.org, Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Miklos Szeredi , Steve French , Ted Tso , Matthew Wilcox , Pavel Reichl , Dave Chinner , Eric Sandeen Subject: Re: [PATCH 07/14] xfs: Refactor xfs_isilocked() Message-ID: <20210617085319.GD32587@quack2.suse.cz> References: <20210615090844.6045-1-jack@suse.cz> <20210615091814.28626-7-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu 17-06-21 08:53:28, Christoph Hellwig wrote: > On Tue, Jun 15, 2021 at 11:17:57AM +0200, Jan Kara wrote: > > From: Pavel Reichl > > > > Refactor xfs_isilocked() to use newly introduced __xfs_rwsem_islocked(). > > __xfs_rwsem_islocked() is a helper function which encapsulates checking > > state of rw_semaphores hold by inode. > > Looks good with the updated commit log: > > Signed-off-by: Christoph Hellwig I suppose you mean Reviewed-by, don't you? Honza -- Jan Kara SUSE Labs, CR