Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp257855pxj; Thu, 17 Jun 2021 01:57:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5biFs3vXhNcuPXXMcD8fwKI3r114BBfyHcOUOrJteUpl55Pdr11P99bBReqUYS9vyiRDi X-Received: by 2002:a05:6402:51cd:: with SMTP id r13mr5109057edd.218.1623920230322; Thu, 17 Jun 2021 01:57:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623920230; cv=none; d=google.com; s=arc-20160816; b=M9TGVU3utEt9MzKvqIa3JFqitMpk4ltEMkHakkKBgcdPgGRQg7awsnadUFuEs5JB3D g7Yq75LkzFWV3ddB4z7wXL/FFRQ5VXlh/lKf9GqABiQmFGrQ9y3UDrVuKOrdpqfGHvVq NbW8x0oxwFd+ZH1ZQu7sRd/8AplwBOnSlNXlmp1H6xW9hqQK5d6OuI7KAPiZ/xxknu6s cqGisq52zSYJ5SN5SaMaqoZk+WOlZ36L4R2mGiOekpw76jjRLjlM+n1ZPl2qb399U8Sg 574jj61pbU2lT7H9RGrKykwRz7SoWjuQpRLGgMVQu7+SBtEwVzIYC6SPKVftKmED/rfk s+XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7kLQp6MYKDk8/sAaxwp980AGLDLmbDndmOr3pBheMP8=; b=ufpTvNKMqcxwkfX2/neazTvF+pN6pgggLdN965iTGiZ611B2UxkVlEY9S5I3tGBxyl 8LLRk6I/Q4LYxCgTmLoB86BRxatdiR7q6F6+4V0g62kvibGrzrvxi4ZnhSPNois8CLBH DACrohy/bmr804mZ2Ih+9A6eywDmP/qi441k6B1E5U5RC5zmp3PIvW6jIt1Mb8Z5SdB1 IVGq+ZFin6chXHLWIxMQ5QUnXmLR0gQ/bYQlfr58ZPEUUU+IXxs9/9KTgy6sOE+H2viY c55rKVI5Kapmjptjo5p+tbybwLjV0epiCVovJUQYUwiZrs3bnlMSOv95VlhQ4NLVD0tv 0F3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=s8gPNuR5; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jz16si3767570ejc.342.2021.06.17.01.56.46; Thu, 17 Jun 2021 01:57:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=s8gPNuR5; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbhFQI5U (ORCPT + 99 others); Thu, 17 Jun 2021 04:57:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230291AbhFQI5U (ORCPT ); Thu, 17 Jun 2021 04:57:20 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16B14C061574; Thu, 17 Jun 2021 01:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7kLQp6MYKDk8/sAaxwp980AGLDLmbDndmOr3pBheMP8=; b=s8gPNuR5E60SDx/0jvFuG+ztKT LhkO7ekXck3IFxpaFRh0aXcx68zPSCb9j8qEojrfsBzB458A8Wpo3blG/4i9Fgwvbw3TjTMpCRW59 VDdK549e9Uj+LlQ4b0QFL2VyktYjZNBGvUW6vlpaztsCzTyyYhazCPnhn1tUZ5f4pnweFZ+zoTfcW vi3pQgHb9r1oipRjtDslyHYP3KK6c5uEA0YJ0qhlIfuVzu7oTLsvgGpZktf1hxdc8y2w+1WnpyYtm 5hFg7oBbDir+o13KteeAI+h/AHOcmJHO7kEJdITTE4WSd+WSgTmHe3mKfyx7gYxOZETR30oq6EHa1 6BJ7DQog==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltnnN-008wOt-0k; Thu, 17 Jun 2021 08:54:45 +0000 Date: Thu, 17 Jun 2021 09:54:41 +0100 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Miklos Szeredi , Steve French , Ted Tso , Matthew Wilcox , Pavel Reichl , Dave Chinner , Eric Sandeen Subject: Re: [PATCH 07/14] xfs: Refactor xfs_isilocked() Message-ID: References: <20210615090844.6045-1-jack@suse.cz> <20210615091814.28626-7-jack@suse.cz> <20210617085319.GD32587@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210617085319.GD32587@quack2.suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jun 17, 2021 at 10:53:19AM +0200, Jan Kara wrote: > On Thu 17-06-21 08:53:28, Christoph Hellwig wrote: > > On Tue, Jun 15, 2021 at 11:17:57AM +0200, Jan Kara wrote: > > > From: Pavel Reichl > > > > > > Refactor xfs_isilocked() to use newly introduced __xfs_rwsem_islocked(). > > > __xfs_rwsem_islocked() is a helper function which encapsulates checking > > > state of rw_semaphores hold by inode. > > > > Looks good with the updated commit log: > > > > Signed-off-by: Christoph Hellwig > > I suppose you mean Reviewed-by, don't you? Yes: Reviewed-by: Christoph Hellwig