Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Jun 2021 10:50:02 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Zhang Yi <yi.zhang@huawei.com>
Cc:     linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz,
        yukuai3@huawei.com
Subject: Re: [PATCH] ext4: cleanup in-core orphan list if ext4_truncate()
 failed to get a transaction handle
Message-ID: <YMthGuTCuRlZ/zL0@mit.edu>
References: <20210507071904.160808-1-yi.zhang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210507071904.160808-1-yi.zhang@huawei.com>
Precedence: bulk

On Fri, May 07, 2021 at 03:19:04PM +0800, Zhang Yi wrote:
> In ext4_orphan_cleanup(), if ext4_truncate() failed to get a transaction
> handle, it didn't remove the inode from the in-core orphan list, which
> may probably trigger below error dump in ext4_destroy_inode() during the
> final iput() and could lead to memory corruption on the later orphan
> list changes.
> 
>  EXT4-fs (sda): Inode 6291467 (00000000b8247c67): orphan list check failed!
>  00000000b8247c67: 0001f30a 00000004 00000000 00000023  ............#...
>  00000000e24cde71: 00000006 014082a3 00000000 00000000  ......@.........
>  0000000072c6a5ee: 00000000 00000000 00000000 00000000  ................
>  ...
> 
> This patch fix this by cleanup in-core orphan list manually if
> ext4_truncate() return error.
> 
> Signed-off-by: Zhang Yi <yi.zhang@huawei.com>

Applied, thanks.

					- Ted