Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp524556pxj; Thu, 17 Jun 2021 08:02:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzXKWUk+pbfwqM025IgRdALL+J7VBOBKr4ETTPDDgyXSkkwH7XhGCS5lZitTdXRdRd2b5D X-Received: by 2002:a17:906:7b4f:: with SMTP id n15mr5664553ejo.220.1623942130771; Thu, 17 Jun 2021 08:02:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623942130; cv=none; d=google.com; s=arc-20160816; b=qSsIT+iWSZRHBhkH3+odruHFKJsHj/88pmybDLIys8xXf0RPYHxoZgQUocWpFiE30X gsxOP1D8QZPltSurBYQY6k/PCXnPBYazBJCMiH1bY3gGWgkIQGXm/aPdQGOs5fk5Jy29 symfriQTFxwVolIbvVRnYm+G9pZuB+XVRnLJXfAmTqjm7Xd8Tr2i78lnu/ZMuXTaOqlF 5pseayKwRUzWC7l/EA6cHMo+P/ajgRml+2Q/ILS1HUi2ZCL6/pFQhdroLaONCnEQGJT5 gz6/whpVgkV9d4vAWYdJFyHnZVLJyiHzdpy/K6T71AD2y4+uWLRPP/ZGyKLjzT2vqc/E kQXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=hZ2E3OwWiaLK7iFxMiCRqgbFgGYMwYrACdY+DacGdI4=; b=lwds7yK8WXCgZXHoeA/7oW9brvRia2vc3GxZCOdzWzYp0bP4/FlpzIHWdv2sk2i7MU ZI7x3WMIjDKzkTAW/sT1pkG6dHTU6P9/T/KjSIbyRD2VGZ+u425pcr3fspJNouoSWjHN AK6e0wLgxGHJMv3CDHPSrtCDS8e/driKk/OseturRopvQ9K1V5G0o0G1ZdNPOWOzNHKC 7d0rykjOhNPosyL+sw4u+rDBpkGtFMPQGWtyyRvy1DuDQoj7kjLKwDLBp+TZYUo5VaUh c8TfSq5lsGkIf/auVgw4Nn1M3oZlkpowhpkBMIzYmmp8rr4rdLSutWQxcVcMr6ACRO2S YxmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dz21si5425589edb.281.2021.06.17.08.01.43; Thu, 17 Jun 2021 08:02:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231656AbhFQPDa (ORCPT + 99 others); Thu, 17 Jun 2021 11:03:30 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:50125 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230507AbhFQPDa (ORCPT ); Thu, 17 Jun 2021 11:03:30 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15HF1AHH010114 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Jun 2021 11:01:11 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 7C5AD15C3CBA; Thu, 17 Jun 2021 11:01:10 -0400 (EDT) Date: Thu, 17 Jun 2021 11:01:10 -0400 From: "Theodore Ts'o" To: Tian Tao Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org Subject: Re: [PATCH v2] ext4: remove set but rewrite variables Message-ID: References: <1621493752-36890-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1621493752-36890-1-git-send-email-tiantao6@hisilicon.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, May 20, 2021 at 02:55:52PM +0800, Tian Tao wrote: > In the ext4_dx_add_entry function, the at variable is assigned but will > reset just after “again:” label. So delete the unnecessary assignment. > this will not chang the logic. > > Signed-off-by: Tian Tao > Reviewed-by: Artem Blagodarenko Applied, thanks. - Ted