Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp809860pxj; Thu, 17 Jun 2021 14:33:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtpHr1IkBDkHw1JjKViuMvieuGlqLX0GiwqMuOG9mbGRSMQYh6wtyMCnDlriU6qO9acffz X-Received: by 2002:a05:6402:358:: with SMTP id r24mr490917edw.69.1623965580352; Thu, 17 Jun 2021 14:33:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623965580; cv=none; d=google.com; s=arc-20160816; b=Nk7dHTQuisIxrXofFUaQfgXEiRtRmESjpP0ZNTFNa/o0Aaj9oQAYS57/8vWxes2Evo rdoVSgH+pOAr8zaQyYwY9WccCxZXnn6+sFDE45w7VinIa4wu1r4mFn+ppOdbYM6qqTBa 5UZPJaxMfPdL8KzHTxYf82OUG/jFgPSx+lPV/Lp1km/kwcivAqTEUN3k5Lmy1Xi20aKw dHk/6Nt3PL6ZMI5XJadiof3NqDDfbLoPvigfAVPFqfI94tPUc/ZkGmiugKvWcFxVRKa7 l9A2pz8o7ukgjCRVExTVMj8BHzftEF5bF1t5KlT7BygMZBI7WDjetlRFMJpuDe8ruxPa 1V1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=rxnAapTVB+eNbEMpmkRsHDAQX1s63vODweor1nELTs0=; b=glXLvqg4Cp7OquA6hz+Y1XLETTM0h/cvrLyAAV9TCXiN+zkhCDr4y+os07aYixccPL LaEmV/hESqmo7i7yqGTtNZo7o2Lpx/CBg92Pv3AgyKLeBAGbwh5c8DI3gA2mnKmVvVik tmVoFd/wkBul7nqTVmohk1C6SGph8om2zXIIfjHG/gU5NJPu64cEEYx78R7fGFGpiJyT xFMkzTTPfix0SuHVLSZTM6PocXLPa4T8MH/PAnvmJwqDpsBaY6J0tpH6wpIRAjoD5QO/ 2Y3CjCeGLD25RAn0G1QIgc8m3RVB8nFRrKSfW+Czjza1GTlBoLEV+V3HI+HNYVH4ZZI9 JXVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a9si179780ejj.647.2021.06.17.14.32.36; Thu, 17 Jun 2021 14:33:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232640AbhFQUT1 (ORCPT + 99 others); Thu, 17 Jun 2021 16:19:27 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:44757 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232624AbhFQUT1 (ORCPT ); Thu, 17 Jun 2021 16:19:27 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15HKH9MD010261 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Jun 2021 16:17:09 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 494C415C3CBA; Thu, 17 Jun 2021 16:17:09 -0400 (EDT) Date: Thu, 17 Jun 2021 16:17:09 -0400 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz, yukuai3@huawei.com Subject: Re: [PATCH 2/2] ext4: correct the cache_nr in tracepoint ext4_es_shrink_exit Message-ID: References: <20210522103045.690103-1-yi.zhang@huawei.com> <20210522103045.690103-3-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210522103045.690103-3-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, May 22, 2021 at 06:30:45PM +0800, Zhang Yi wrote: > The cache_cnt parameter of tracepoint ext4_es_shrink_exit means the > remaining cache count after shrink, but now it is the cache count before > shrink, fix it by read sbi->s_extent_cache_cnt again. > > Fixes: 1ab6c4997e04 ("fs: convert fs shrinkers to new scan/count API") > Cc: stable@vger.kernel.org # 3.12+ > Signed-off-by: Zhang Yi Thanks, applied. - Ted