Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4967329pxj; Tue, 22 Jun 2021 11:58:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqSLQ0QqWk6HpxnL4sw04gbVBCSBZg1wfWvSVA4kWkd8p3TQ5RkbGLeE4TwU6Rs5d0TSgo X-Received: by 2002:a02:b0da:: with SMTP id w26mr891471jah.42.1624388335953; Tue, 22 Jun 2021 11:58:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624388335; cv=none; d=google.com; s=arc-20160816; b=IGw77OptiMIfGFn57JZzAiiOAx2V67KoaK2A1lXmfpVMds1bpPz/HdhQdbcq7He8Vv 4j62oBkkg7zeQWLHg76NrXEdypdj6Q6ZiWR0yAEeqBnIx8S1HseOuV90P+5tU1QUFkD5 p7a9tWpgNeWe43UVmKo1YD3z4oRP5JfO1zZbFnSzlLK+9zrNc4cO0Qznk5NXKMgS+m1F EctVP+vYyeHIi7JxN1GFGQ/QEwQOW1Wv7wqbsUQq10x5aiRnS18FyCKKbEHqfaH9C3qM CyflkHX38Mo0gJt+alxfHjRax24AbemaF8Wq2Z2iO2e8RUMX23BOoAJITGDLk8W3VAwz 2/3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=xPk7T/ftbiBmPf+o6AYQ5V0HnU5NGPQBeJe2s6miHI8=; b=YB2Xal4vlBkllLDtB0u5w1+8LmSLIuqSSaVQvcYY/9y6JlvsMU8gZLuMXOfmmCIQjv a4W2qBacZOFqCf62Dn5P4m5sAaMYq37XOKHGvM5XOH5FQ/cTBitrWcZPggJNBG4oGO0H +pLSqRusGGOtyoEE6RTwKUu8l9L6rImuBFx6ISVGxucEpUhOO4WnmcXJkJS1NHIQz5WG iSOsDTVTNrNeir3RZGSy51lqPekPuO+9MRC1FuQLWixjFK3SNsb9nyuT3PvLbtcPUhQq DDVtGUPWBnj9y8HaYWTQp0Mb4OqwbulkE8/6UFjqZs4ccC8x75ZcPVUNb5XQTb82EX3m K2/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=VhTAedbT; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v6si18412994ilu.109.2021.06.22.11.58.42; Tue, 22 Jun 2021 11:58:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=VhTAedbT; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232571AbhFVS7w (ORCPT + 99 others); Tue, 22 Jun 2021 14:59:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232627AbhFVS7w (ORCPT ); Tue, 22 Jun 2021 14:59:52 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62026C061574 for ; Tue, 22 Jun 2021 11:57:36 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id d25so3511601lji.7 for ; Tue, 22 Jun 2021 11:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xPk7T/ftbiBmPf+o6AYQ5V0HnU5NGPQBeJe2s6miHI8=; b=VhTAedbTxJDC60DaO13KHKxcUeyU8ENl3RSl3vIntzzeRYtWM0BVNQZJ7sDNpmRFQO Ucorn0ijH5dvTGTuXlecFzoOE2aDg/bX3NnRpMk0K++RjVnfO6xG9mcKG8RMdHCWoqbH 9yUMAp0MAks+wmHiCn2j+g4RTxHlsJd0MRqpg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xPk7T/ftbiBmPf+o6AYQ5V0HnU5NGPQBeJe2s6miHI8=; b=NbpXYU+KFuSGfLhkOHbT47hrqjgo/IbbCO1Dt3ktXxVxz1nxpUx/0TBupUeyeuh3Yl rqrkBmu3golwrjJKTEFr+aWCR9txAmQJ8qyiRz3igyxu7s1udWtzublx4n232Bd/XpSg q3+DKZL1kghaNuXoxQMMdhi33aZHF4Yz8W9LlEELRcTHGRIccdnOFB/rN7G1h3nbIKii ZF+99ZRi7FtJ6k6UEAdvp+Wf+moJY3kvOR6L/eckTPOK78JaS4pPW2HXpWg92LT64C2j yeTkJyeimPUccY7H07bXQzU749GQi8ueJx9J0QMB93ubgGuwD6yZKSscDaX4z0ncxZA4 b3UQ== X-Gm-Message-State: AOAM530LWoj6oXevJZwyf0EFRcy3Z2t4ddqigXqHjAiQovODD8XEtIc2 XQ5unAjaPL9JIBAz/+hA5ner7p26CNxl77NKfNY= X-Received: by 2002:a2e:9a41:: with SMTP id k1mr4502028ljj.248.1624388254546; Tue, 22 Jun 2021 11:57:34 -0700 (PDT) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com. [209.85.208.182]) by smtp.gmail.com with ESMTPSA id e13sm683431lfc.111.2021.06.22.11.57.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jun 2021 11:57:34 -0700 (PDT) Received: by mail-lj1-f182.google.com with SMTP id c16so757ljh.0 for ; Tue, 22 Jun 2021 11:57:33 -0700 (PDT) X-Received: by 2002:a2e:22c4:: with SMTP id i187mr4487018lji.251.1624388246482; Tue, 22 Jun 2021 11:57:26 -0700 (PDT) MIME-Version: 1.0 References: <3221175.1624375240@warthog.procyon.org.uk> <3231150.1624384533@warthog.procyon.org.uk> In-Reply-To: From: Linus Torvalds Date: Tue, 22 Jun 2021 11:57:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Do we need to unrevert "fs: do not prefault sys_write() user buffer pages"? To: Nadav Amit Cc: Matthew Wilcox , David Howells , Al Viro , "Ted Ts'o" , Dave Hansen , Andrew Morton , Linux-MM , Ext4 Developers List , linux-fsdevel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jun 22, 2021 at 11:51 AM Nadav Amit wrote: > Just reminding the alternative (in the RFC that I mentioned before): > a vDSO exception table entry for a memory accessing function in the > vDSO. It then behaves as a sort of MADV_WILLNEED for the faulting > page if an exception is triggered. Unlike MADV_WILLNEED it maps the > page if no IO is needed. It can return through a register whether > the page was present or not. Yeah, that looks like a user-space equivalent. And thanks to the vdso, it doesn't need to support all architectures. Unlike a kernel model would (but yes, a kernel model could then have a fallback for the non-prefetching synchronous case instead, so I guess we could just do one architecture at a time). Linus