Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5653283pxj; Wed, 23 Jun 2021 06:14:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9W1UJrHvvIXqXecmcuyPyyPVhN2RGgWaomem424kqIhOeYnfmMR/HtQTuD5rJs3dPgjYQ X-Received: by 2002:aa7:c3d6:: with SMTP id l22mr12431466edr.245.1624454063338; Wed, 23 Jun 2021 06:14:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624454063; cv=none; d=google.com; s=arc-20160816; b=QyfcB+WpUJzLtRh3Wqq0y1vnPjCmx8/rzMACD9uLSOZWknnUvMiySIvkzS45PWQVeP umHFRGepX+FdOBk8EMk+yC/N8MniwDzydVNpZwPMET1VJ8B8VWLUv0qAcRM0G6mlTVU7 zy3yCbWhCRdGDhTgnR6huRAl1ghiceVPovQkRcjb4oJNJEhkM7siMuyJzadalOA77GBF kwIYISlhCHvN61tNuoAiYJFocRsUx0I43UDhDVAYUxpGvEDUogl0OvNQRt1gTycSipLg TGq/tcPIrJccHldANQScAsp+2tAjN+WgqkAcYV6/vpWUtnx4ZBJISQNPL/aAY847Xd57 fLsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=GQScmPqNiAcJeg7C1FlMyBp6Gnq7t2jlQUfIXHY9XNU=; b=d6OAeC8dJhni1kTEagxlrgoCjJGd7ZsFRwtZPZSVQx/Z74UYcVN1yg/f/PC5EIGBxz O/2PKVI8g1EToPix7OEZbuCtctbXz8rtIt/bM7fEbSmMIUG6semACuU+8iqXHXhG+04u f37A/8Dra/VZgZuAmEcBgN6jwTJh+sNfOJFQHXgYN++yuqD1gRyGQHrJOy+cR+UXycYp /t5llUIsiUzF2nw3AH3fn+9zqpDGWij/ud3fvws/ZVwzfpcBZv13r5bBxHxFJQCVBhWh b2TpDHuLcfGQIz9wIXtQOTytKfv343og5uFZBgTdqpOE05WTxLtVhin3aIR41nAJRmbz YraQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h9si8825820edt.358.2021.06.23.06.13.56; Wed, 23 Jun 2021 06:14:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230306AbhFWNQH (ORCPT + 99 others); Wed, 23 Jun 2021 09:16:07 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:52954 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230206AbhFWNQH (ORCPT ); Wed, 23 Jun 2021 09:16:07 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15NDDg0Y022614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Jun 2021 09:13:43 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 4420315C3CD6; Wed, 23 Jun 2021 09:13:42 -0400 (EDT) Date: Wed, 23 Jun 2021 09:13:42 -0400 From: "Theodore Ts'o" To: Wang Jianchao Cc: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, lishujin@kuaishou.com Subject: Re: [PATCH V2 1/7] ext4: remove the 'group' parameter of ext4_trim_extent Message-ID: References: <164ffa3b-c4d5-6967-feba-b972995a6dfb@gmail.com> <61eceb4c-6e5f-34d0-9317-a833d7c63b6f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <61eceb4c-6e5f-34d0-9317-a833d7c63b6f@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi Jianchao, FYI, this patch series has confliects with these patches, which landed in 5.13-rc1: 196e402adf2e - ext4: improve cr 0 / cr 1 group scanning 4b68f6df1059 - ext4: add MB_NUM_ORDERS macro a6c75eaf1103 - ext4: add mballoc stats proc file 67d251860461 - ext4: drop s_mb_bal_lock and convert protected fields to atomic The conflicts were relatively minor, but the obvious fix-ups resulted in a large number of crashes caused by various stress tests, such as generic/068 and generic/204. I'm currently investigating to see what I might have messed up when I tried applying these patches, as well as running your patch set applied against 5.12 to make sure the problems weren't introduced by the patch set itself. - Ted