Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp252785pxv; Thu, 24 Jun 2021 07:13:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYLIoIXlUne4XXPeezJdYYpzw4GxDqtsS23Mq9upnpssmMXatt8MYkxLSrKiqC9eEVe46O X-Received: by 2002:a05:6402:34d1:: with SMTP id w17mr7287089edc.167.1624544018923; Thu, 24 Jun 2021 07:13:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624544018; cv=none; d=google.com; s=arc-20160816; b=o0SYt0+81ay/1kZZlIDeBjijlbT9jqukduAQs6H9OTscc/swcFXLiA7DlaWA2SYk1S 1CY9phXszTobkXlyi7kWQmkQw7DvKoa8kQmeSVxx8PCBoM0VIgbuTOmAuS8TqB7A5fOG /VDbRZI6kyhfLWEHueVYpDcm8/O9E6NWCtGKMy89ZjSqRTa9du3BdQVmR8OCQlp5jc6E 6Bn8iC9ahLaYiKbXz5GEguKp9vUWoaVl7AyiIKZQ5ff70Ajz1Y2Rbijucqrwp/J7JQv4 PaFsRPuRR6eId05oYiAloHOuDqq375XUgxgf3QbXQGvEfsC0/Vjum3N4xZ6e3kFgvvWP XGwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=U0nr6KWx4+y2kOutVdKgiJljtMfFgq4GuoRJhh7cqyw=; b=PJzfwSrK5GuxOM+u0bPhzAQVybAARVmeEx/Yd4sNh0ALh0FGuzqiX21Z/G7wJAYxxV wcNXCLwTsFpmFvWk6b4OrZ4S7JdHr1t5Q6NpF/ulPBIYM3sk9eF3SPxKAu4OhmVlN2Gl JuLum82tzudC44nGA2pNfDBDjE11JtSEspM6kd89fOjEr11ATgIjBfqDWhoRrqKh+oqv 0aa0e2DQbSaw9ygCzWtcWccOgSYL7QFG2C0svb0PYSzqIKLYb3tLtnjKRiAmcw4H6fkR Vye+4MHfkWZmeJqGdvqFm3iZjDOMEIXBIgvqGmPSkFhTb3U+DlKuQRyq468bNduiL7dK U05w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j8si2774731edj.124.2021.06.24.07.13.10; Thu, 24 Jun 2021 07:13:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230249AbhFXOPL (ORCPT + 99 others); Thu, 24 Jun 2021 10:15:11 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:49703 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229878AbhFXOPL (ORCPT ); Thu, 24 Jun 2021 10:15:11 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15OEClXA028393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Jun 2021 10:12:48 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 6FEEB15C3CD7; Thu, 24 Jun 2021 10:12:47 -0400 (EDT) Date: Thu, 24 Jun 2021 10:12:47 -0400 From: "Theodore Ts'o" To: Ritesh Harjani Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: Remove duplicate definition of ext4_xattr_ibody_inline_set() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jun 03, 2021 at 07:33:02AM +0530, Ritesh Harjani wrote: > ext4_xattr_ibody_inline_set() & ext4_xattr_ibody_set() have the exact > same definition. Hence remove ext4_xattr_ibody_set() and all it's call > references. Convert the callers of it to call ext4_xattr_ibody_inline_set() > instead. > > Signed-off-by: Ritesh Harjani Thanks, applied. I modified the patch to preserve ext4_xattr_ibody_set() and remove ext4_xattr_ibody_inline_set() instead, to make things clearer; otherwise people would wonder why the non-inline functions were calling ext4_xattr_ibody_inline_set(). - Ted