Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp256636pxv; Thu, 24 Jun 2021 07:17:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDkLOS7Df1nIj4CW+4L4bftxDG+91iaZp6ab8swV/Xag7vnCx0JnfxaY9B7gPimzgbIICr X-Received: by 2002:a6b:d009:: with SMTP id x9mr4304859ioa.199.1624544263273; Thu, 24 Jun 2021 07:17:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624544263; cv=none; d=google.com; s=arc-20160816; b=Bu9wgAMCWpS1jlcDVXXiWAsb8cBFpKAX2WFcEMn4+cP2B6EH4i+G5B1hqvIswOa4f9 iUR4qb3pZ9dhraQVJnZvzLRRMCfs9NIod1JEGpaBH9z75fAFF+5y/gMRrBwG3fjVyaR5 jNyX3si+NuNO0sog9NSwrV4OMC612kYNV1pjC2EVARyaQOTAhLRxc7pRYL/RkNfNCRmT PwRShVtl0gabijNMPEQ40kE/z9g92AC4i+ExvA+i7wneTXCR1DwAD6JavS6a1pmnZkBm e8uc3Uxd4XTlRcU2Yu7C0m4EYZFHWx4EeCSYdxePW8yYJqdD3j1m4isC1NjC8RFDptDu sQXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=keqPtM3NIuVCTUWQ8ybEHmqPs4RDGQbRbBK+6dJBwaY=; b=FC2I91yl3MbaBR7jSlvqx3b7Q0HW50xjE8tkqZveUxo0jsEM5+tUDKSqU54giz3fxp wLaQyI2Mjg+6mDIzP0EzWJmKYF3f6mMLKH3E4oG8HOkzYSuMFdtHkPsFktOnlslWjRCW jME5FFELnHRwTpyYfjuCd/hcTNOgxM1T3wdPxoPNUmMxfkRv9fM7yMrsBVV/W1i/yA76 UvFACuXk+ChDLJev0/3LaEUenBvsVTu1GbI3vsdi1jEaZ6KHRWUIl/F6JTtKaUnVl7+q OzUlU7BviiITNHGbWmjVoV6l9E+CVoEuhdpKuGNZT/lC+yb8GnAEuBsBy85sJw0JX3Ky sL0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u18si3639271jap.83.2021.06.24.07.17.24; Thu, 24 Jun 2021 07:17:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230056AbhFXOTh (ORCPT + 99 others); Thu, 24 Jun 2021 10:19:37 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:50354 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229878AbhFXOTh (ORCPT ); Thu, 24 Jun 2021 10:19:37 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15OEH5xn030201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Jun 2021 10:17:06 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 7D90515C3CD7; Thu, 24 Jun 2021 10:17:05 -0400 (EDT) Date: Thu, 24 Jun 2021 10:17:05 -0400 From: "Theodore Ts'o" To: Leah Rumancik Cc: linux-ext4@vger.kernel.org, dan.carpenter@oracle.com, kernel test robot Subject: Re: [PATCH] ext4: fix input checking in fs/jbd2/journal.c Message-ID: References: <20210607175558.3343945-1-leah.rumancik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210607175558.3343945-1-leah.rumancik@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jun 07, 2021 at 05:55:58PM +0000, Leah Rumancik wrote: > Update > > if (JBD2_JOURNAL_FLUSH_DISCARD & !blk_queue_discard(q)) > > to use && instead of &. JBD2_JOURNAL_FLUSH_DISCARD is set to 1 so & > technically works but && could be a bit faster and will maintain > correctness in the event the value of JBD2_JOURNAL_FLUSH_DISCARD is > updated. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > Signed-off-by: Leah Rumancik Thanks, I've folded this fix into the base commit. - Ted