Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp272384pxv; Thu, 24 Jun 2021 07:37:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzx1lx2QcX6y2XbwGVbN3FkO/rFPyn8n+m70OdcyzDirz8JvvPL0Dw5FcpEB5+5ZQEbYB9x X-Received: by 2002:a05:6402:1c8e:: with SMTP id cy14mr7768285edb.271.1624545460325; Thu, 24 Jun 2021 07:37:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624545460; cv=none; d=google.com; s=arc-20160816; b=DPWyVsxs2TD9LijoUESfAb0WQtJLXUjQ+MCwQo9s3fnBf0FYFZgGINf3jisoTPGHzn iHTv9lIKIsPCM8u62vtE3aQzLDD10/MH6XoZU+PYeBYp3aQcOPovVASmDrqASdn76Ka1 Yz7m55gbfe+rS8PevayS9KqoIyhCkVvE4su4PQL0QyyHXVdfUo76OCizuBEKAtlJtNrJ /Ncg1E+ZRIT6KF8SECcRFtO3v7HVyhJ/d/VqwXasatLqI5Fvh0n+HkvDX484eM5ppNJx thpnkcyllkPiWCpbHw2qJZtXLoZ/kNscrk4X2qMUjQNPY1MYKNycP6aXJS46q1jr5HFn QkdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=HJRzylgvW9K+oPfhU0Z2iX0fAJfPcCUfquQ+r+7sPcQ=; b=nVLB8TicWQnvT1bx6U6zBuFoDA+T3Nisyus31GOKy6Si9cFITzNrTAJ2+Oib0X5qCW 1n6D/vxTmK8NDVCA3NeOY+5+fJxWVDTomRuCzHZ6+/C2+BemCIWAGM94yjicBPl/qgjK m2BYxuhUobNb5ojd6sGdSV3teV4E86Zxyvqh8ib3jiRs60gzCuVFQJIWNoxa+hb6JfRo t8t8hlYWiccFqikEuW0SGvYy9X3Nz/j3n7iwrNdT8i/WWLYvLuXkIIaPH10XP1bR5Peg cq2Zd8EB1r+lXkJ43Z2j3ScmuNJHdvwfnu5WDcd4p5ypoXuhuEU0o9e4cq6nYPmyc0Pu s8yA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id aq17si2857527ejc.70.2021.06.24.07.37.06; Thu, 24 Jun 2021 07:37:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232178AbhFXOig (ORCPT + 99 others); Thu, 24 Jun 2021 10:38:36 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:53460 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231487AbhFXOif (ORCPT ); Thu, 24 Jun 2021 10:38:35 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15OEZCT8005958 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Jun 2021 10:35:12 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 1FC5115C3CD7; Thu, 24 Jun 2021 10:35:12 -0400 (EDT) Date: Thu, 24 Jun 2021 10:35:12 -0400 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, jack@suse.cz, adilger.kernel@dilger.ca, david@fromorbit.com, hch@infradead.org Subject: Re: [RFC PATCH v4 1/8] jbd2: remove the out label in __jbd2_journal_remove_checkpoint() Message-ID: References: <20210610112440.3438139-1-yi.zhang@huawei.com> <20210610112440.3438139-2-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210610112440.3438139-2-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jun 10, 2021 at 07:24:33PM +0800, Zhang Yi wrote: > The 'out' lable just return the 'ret' value and seems not required, so > remove this label and switch to return appropriate value immediately. > This patch also do some minor cleanup, no logical change. > > Signed-off-by: Zhang Yi > Reviewed-by: Jan Kara Applied, thanks. - Ted