Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp272916pxv; Thu, 24 Jun 2021 07:38:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZoFq1mWOhTquBpx2prOGxAURyrAirNn+vmVJGY156nZN/eUE5DFq3rJfLrRBIbF3zXL7o X-Received: by 2002:a17:907:9da:: with SMTP id bx26mr5472214ejc.262.1624545499518; Thu, 24 Jun 2021 07:38:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624545499; cv=none; d=google.com; s=arc-20160816; b=MOGw0VdFdmqZMaVcwHSQgnIxwcXBB/XXWb2c/A7JwYG1D0r+klroLOi93wr8sAEny6 V3kvGTe3GOS2GZvwhfDLdQ4b1Rm4uQcQgoOOW1AF79ZsXCv9Qo1kN91JIxUB8ppe9vKD K3N8bXMhD62OEoCK/Yns6PQO5sghRpcfw3Qtf+FJ4kec5lsa8A+LKfmW6Mf2NuRZ16Ig +fTyu1+5ptVCoS0yOtMN3wrwp/CL+uyLQ7SCKZ5yYJXa0XnKyNOMqwfXvWTphBmDLH6E 2neN1oHyLmqsUreofEoeY2SpBUDl+bxSVaFp79M1jg9P3iNDmJcURUZYIrS3XOHA1dVU vzpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=BnGiIhm/EMk0eC0nqEviezAsv4UcA0Ff7oTSKmAjqAU=; b=fbqI5eHDVP88lBnWec540ibVgHyAb7Fl1KIlA4c4mGswAmEwCa25rFIe3d/NY/ZLBm KtkreTh2MGo8vM7sGLfeOkZwuChXdG71v9LosTv4SbjHJ1uyD/sfM/JuFH+tmONvMlp1 ede1tTO7JNJTSwAGtCia5nsI+J5MuaLjX3TQ1wAzimyVeV0ade+agABVO3nz0gRjNST5 PY7YuL52Psi1GEbdWXn31cC62FgxhXIyhDRDQgMcNykEuirJsbPJLwyYMZkPJ38SLQlw l+lfszR7AWIJoOi3f1me9KsMD7KqRNZ772ybIPUXaE/UojhwdXmPWbisIem2eg+eEDLh mbCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hv6si2972165ejc.150.2021.06.24.07.37.55; Thu, 24 Jun 2021 07:38:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231487AbhFXOjP (ORCPT + 99 others); Thu, 24 Jun 2021 10:39:15 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:53559 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230170AbhFXOjP (ORCPT ); Thu, 24 Jun 2021 10:39:15 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15OEZuLb006267 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Jun 2021 10:35:57 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id CE1BD15C3CD7; Thu, 24 Jun 2021 10:35:56 -0400 (EDT) Date: Thu, 24 Jun 2021 10:35:56 -0400 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, jack@suse.cz, adilger.kernel@dilger.ca, david@fromorbit.com, hch@infradead.org Subject: Re: [RFC PATCH v4 4/8] jbd2: remove redundant buffer io error checks Message-ID: References: <20210610112440.3438139-1-yi.zhang@huawei.com> <20210610112440.3438139-5-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210610112440.3438139-5-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jun 10, 2021 at 07:24:36PM +0800, Zhang Yi wrote: > Now that __jbd2_journal_remove_checkpoint() can detect buffer io error > and mark journal checkpoint error, then we abort the journal later > before updating log tail to ensure the filesystem works consistently. > So we could remove other redundant buffer io error checkes. > > Signed-off-by: Zhang Yi > Reviewed-by: Jan Kara Applied, thanks. - Ted