Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp287174pxv; Thu, 24 Jun 2021 07:58:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdJGXmiE/PdoNlV14oPDSjytDGCfRt5CSyth2EUxvztRqbxW75+gX0S8G/auwAEU/wo7Ea X-Received: by 2002:a5d:930b:: with SMTP id l11mr4607358ion.177.1624546694313; Thu, 24 Jun 2021 07:58:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624546694; cv=none; d=google.com; s=arc-20160816; b=r5whwnai16AC8dkUnKp0DFA2U1PR3s6NBkDTTnVpYyDBP688ji+icBkrhSLihKhaZ8 QqBEgt4scy2/JCLVvslfGikgG6EyvgvYNfSpJ0tOcGhI/NUwjzwfjZIb6zuJx/CEIO5V iOZwNqMPoikRfSSFl4Dy1YvInV8wsN+6fXIG+bdmo/9dSVyx8TML9AUgSaMJaGdGWOod lBsSeMbhoNxjuRHbOhW5PWVVxWuBfqWRnX8ksuRtpWFXqUWvq/ORPJreTCnsn4JyMATL YrJ9gjxFAaYPSeRKOuHYTPGQoD5p2k+IQoCvg1fphpplftIPjgz8rbmA0kSextSxKKbT ZDKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=fkRg72wKMrqWmUp8kJHbbM04rUD7pFbJr/JfLPIUV74=; b=jqiUaf8N7eWUcy6/bwd0KfyGzdeeahY4FdJPMy69W1dj8cEfIW8KzZ1QpKIQPiKuN/ ju62QKCPB5/3tTj+ldOTrXpcr2munqxajPD2cZGKQo353vYARBO22CLX7GrZFtgtR+zL Dyq/DGc6svqTZfpyc/3o4rMe2BukBscMPC7MD95V2Ll4Sx3DJdgJlfQLn0QqG3UUSPo7 oRs4Xwn9j8qUtsstj5OBou3BfZIQY93BjEo5E+MzAeOaVAc3imtRfP/512eZY6rTW5fr AmBSjUQWUuG42gu/+Ju913vWYhAvm3sJfyPWwCg+Vdjsmwh88uVz+/EWc3CJnEUu2bpw dkMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m4si3269183iln.52.2021.06.24.07.58.00; Thu, 24 Jun 2021 07:58:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231250AbhFXO7H (ORCPT + 99 others); Thu, 24 Jun 2021 10:59:07 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:57100 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230170AbhFXO7G (ORCPT ); Thu, 24 Jun 2021 10:59:06 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15OEuTXM016142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Jun 2021 10:56:29 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id EFF0115C3CD7; Thu, 24 Jun 2021 10:56:28 -0400 (EDT) Date: Thu, 24 Jun 2021 10:56:28 -0400 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, jack@suse.cz, adilger.kernel@dilger.ca, david@fromorbit.com, hch@infradead.org Subject: Re: [RFC PATCH v4 6/8] jbd2: simplify journal_clean_one_cp_list() Message-ID: References: <20210610112440.3438139-1-yi.zhang@huawei.com> <20210610112440.3438139-7-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210610112440.3438139-7-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jun 10, 2021 at 07:24:38PM +0800, Zhang Yi wrote: > Now that __try_to_free_cp_buf() remove checkpointed buffer or transaction > when the buffer is not 'busy', which is only called by > journal_clean_one_cp_list(). This patch simplify this function by remove > __try_to_free_cp_buf() and invoke __cp_buffer_busy() directly. > > Signed-off-by: Zhang Yi > Reviewed-by: Jan Kara Applied, thanks. - Ted