Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp287927pxv; Thu, 24 Jun 2021 07:59:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyt869kROlgMo9ICtTKMymLeGzBuW2Eyu10CIFage0GYF418ALGOeJFGtm5XeREVy2LNBnC X-Received: by 2002:a17:907:1607:: with SMTP id hb7mr5633947ejc.255.1624546759720; Thu, 24 Jun 2021 07:59:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624546759; cv=none; d=google.com; s=arc-20160816; b=aYAo2w7CH88iABoL/4F2tr/o3AUp9w4CVb4ppLsQxIG0hWHX6KzP6RpKLnKRIFACVs cE8G/1w7Z5qKOBvkQ5yfXZkZQcOy+CQzhWf4JEtZiTHCy5utnD+Q+qstD3dmrgfQkiJ8 wUz9KhJHt0y5cs5nxRswg1479H6htLqxt7kNBwPEH7STM6HJUm/+ylXkdedfctu4S/Xh eW3M5yI8NX9CkRqdfSZcEWnZdHHBlDss2wBY7RHYgvD1ddmw/8NHhOBWOs0seL7qdxeM kXLuGnweLwGczrC4/8uUpmsCA4NOq0y4aIrlM7YOA2Iary6vHefCmErATWEQa9BRcUDC Z2KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=xsKemQty9NSqYW86lsdJWXQY6ya2grL9B0l6paUBQVU=; b=gwRW+qbFsul7EXdDhtFOs9tMBM1Bmeq0khabmTk26gx6RHEEyjwLZwyPP2M1Q94njl WQHHuNSVImC7OuWLZZx0ZlH+2yiLUKe+tax9HIBKA2u3fz2rG2JXS4DySFu+dn9KiPFe vGlggP0YmwSQIN7s+KaDIHU6I0ifhbEMOOgGk3e0YK9Gk0wQGnDMlIkVI0NvmWJWjpYi Ht9Wme+YOBjS94klDyNTWk9mizmJpf6cfE3wzQa1zuANSRUYCXWmgp5Cmx8UGMV7RmCM Pte44ZoxtDjGWVih33K//6H424cwH/0Hoqv2Q71OboPEH0zYTOxXwpbE+p3FagOyunu1 py3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si3498955edb.244.2021.06.24.07.58.56; Thu, 24 Jun 2021 07:59:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232075AbhFXO7R (ORCPT + 99 others); Thu, 24 Jun 2021 10:59:17 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:57137 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230170AbhFXO7R (ORCPT ); Thu, 24 Jun 2021 10:59:17 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15OEuhRg016173 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Jun 2021 10:56:44 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id CD08515C3CD7; Thu, 24 Jun 2021 10:56:43 -0400 (EDT) Date: Thu, 24 Jun 2021 10:56:43 -0400 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, jack@suse.cz, adilger.kernel@dilger.ca, david@fromorbit.com, hch@infradead.org Subject: Re: [RFC PATCH v4 7/8] ext4: remove bdev_try_to_free_page() callback Message-ID: References: <20210610112440.3438139-1-yi.zhang@huawei.com> <20210610112440.3438139-8-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210610112440.3438139-8-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jun 10, 2021 at 07:24:39PM +0800, Zhang Yi wrote: > After we introduce a jbd2 shrinker to release checkpointed buffer's > journal head, we could free buffer without bdev_try_to_free_page() > under memory pressure. So this patch remove the whole > bdev_try_to_free_page() callback directly. It also remove many > use-after-free issues relate to it together. > > Signed-off-by: Zhang Yi > Reviewed-by: Jan Kara Applied, thanks. - Ted