Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 30 Jun 2021 11:04:32 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Zhang Yi <yi.zhang@huawei.com>
Cc:     linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz,
        yukuai3@huawei.com
Subject: Re: [PATCH] jbd2: fix jbd2_journal_[un]register_shrinker undefined
 error
Message-ID: <YNyIAEM2ansIKB4N@mit.edu>
References: <20210630083638.140218-1-yi.zhang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210630083638.140218-1-yi.zhang@huawei.com>
Precedence: bulk

On Wed, Jun 30, 2021 at 04:36:38PM +0800, Zhang Yi wrote:
> Export jbd2_journal_unregister_shrinker() and
> jbd2_journal_register_shrinker() to fix below error:
> 
>  ERROR: modpost: "jbd2_journal_unregister_shrinker" undefined!
>  ERROR: modpost: "jbd2_journal_register_shrinker" undefined!
> 
> Fixes: 4ba3fcdde7e3 ("jbd2,ext4: add a shrinker to release checkpointed buffers")
> Signed-off-by: Zhang Yi <yi.zhang@huawei.com>

Thanks applied, with a slightly clarified commit message:

commit e102693820c5b5bbd56958c0940e7bc2d2f80a5a
Author: Zhang Yi <yi.zhang@huawei.com>
Date:   Wed Jun 30 16:36:38 2021 +0800

    jbd2: export jbd2_journal_[un]register_shrinker()
    
    Export jbd2_journal_[un]register_shrinker() to fix this error when
    building ext4 as a module:
    
      ERROR: modpost: "jbd2_journal_unregister_shrinker" undefined!
      ERROR: modpost: "jbd2_journal_register_shrinker" undefined!
    
    Fixes: 4ba3fcdde7e3 ("jbd2,ext4: add a shrinker to release checkpointed buffers")
    Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
    Link: https://lore.kernel.org/r/20210630083638.140218-1-yi.zhang@huawei.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>

						- Ted