Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp462729pxv; Wed, 30 Jun 2021 09:30:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnjB4WAu/8RfKDpiHxM+DsWryBDh+yP6VnuvM0giPL6zr2hol1fE6uYEJQKpZHFJP5M0+n X-Received: by 2002:a02:606d:: with SMTP id d45mr9778828jaf.86.1625070618697; Wed, 30 Jun 2021 09:30:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625070618; cv=none; d=google.com; s=arc-20160816; b=V1Izoj7b+VHF8T5UL/aZpecy0zkzH3QJO4F+Rf0IgC4gNbPEtS+UgpjYuxeOEc2u9d GZwvKfEYIvKcIZVh2iEc9dzk/3D+lH3atTEaXvAgC/IJC2zN2G6b7Z/ss7CN5FbXx4Wx Yls/tBmhRgIdvwGj/mKrxeDiGHxSKlIgO6ENwNx4M93sMKKupY7sjauVlzqakJmYqS6B NtpXoC8Wawtw7LINQtJBogfkLPESUxTfJFFz4aDeG9lU0SGdndYSwtdcPiYOgcPuLXzo iewM5qIvkf5SmLrris0KsCIrTIq32u1Vx/V+KXLuWfyl/XfKD0edVpDnlOewd+jwkZS/ DbrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=acwD8WC0svbdGxhy7nv2ldrZXh38pOr4Gh3dSmw1vcA=; b=s4ygqjGggMAbj2VlQCBTPaTwKvETmnE7frWWNhqDY3RebIQ416mI2NVV6DnZb9zeZ7 lKdZhiboYBHj1Eot1UunnA6zJY3IecLekehiygS0rFKOYSmStdH0Y+WMVCVnHFxpIUgS vZasN2F42DE52zhGeMSZcUSt6/1bYia183w7uAUuogugDs6co57DVwfuo29iWFyv/mDm OYZ9a4izMuLzreN7bONfXKxMDORV9Cey9zIcT62hA9NCxhSr5fcJhxLOFnLFqciBqHBi kfHx14ADXd53yztH4A/CnT7Mnk3/oFJAwNvD7BIyDz4ysb67HTuyHoDDyoJgpTjqhBPc /1dg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d25si22822617iop.15.2021.06.30.09.30.06; Wed, 30 Jun 2021 09:30:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229548AbhF3QcO (ORCPT + 99 others); Wed, 30 Jun 2021 12:32:14 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:35079 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229510AbhF3QcN (ORCPT ); Wed, 30 Jun 2021 12:32:13 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15UGTe4K004092 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Jun 2021 12:29:41 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 8D79415C3C8E; Wed, 30 Jun 2021 12:29:40 -0400 (EDT) Date: Wed, 30 Jun 2021 12:29:40 -0400 From: "Theodore Ts'o" To: Ritesh Harjani Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 3/9] ext4/306: Add -b blocksize parameter too to avoid failure with DAX config Message-ID: References: <280020a9d6791ad4fc1c51bef9c20771f6791d69.1623651783.git.riteshh@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <280020a9d6791ad4fc1c51bef9c20771f6791d69.1623651783.git.riteshh@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jun 14, 2021 at 11:58:07AM +0530, Ritesh Harjani wrote: > mkfs.ext4 by default uses 4K blocksize. On DAX config with a 64K > pagesize platform (PPC64), this will fail to mount since DAX requires bs > == ps. > Hence add the -b blocksize paramter in ext4/306. > > Signed-off-by: Ritesh Harjani Looks good, thanks. Reviewed-by: Theodore Ts'o - Ted