Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp499592pxv; Wed, 30 Jun 2021 10:20:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9BTeSa5UB8lr40TT4aGuQF/eshIzc+07HwUd2D20R0X0sdmNB6RGg5S3EGyAMlBDyOj8g X-Received: by 2002:a17:907:e8c:: with SMTP id ho12mr4385118ejc.372.1625073630825; Wed, 30 Jun 2021 10:20:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625073630; cv=none; d=google.com; s=arc-20160816; b=S+MsxrDDaeGrdb2xRcrhYZKn2buse4vh30JWka+WWVEFWoMnguCQzZHNAZPYBkiRmm 8CTMfWTmpScUkH/+d/DbLzr/cG0Muhl7hDb1z576hf43xYNUw+XRjPyBnR9nDIJc17La xO9oYtHZRuRti7izaFUQxB5gS62bF/8lckUQ5P3xTvD3jSfQpj/H4vtqvxkDr46cHXir 83yCa/BCiDcSrZchlrdKrZ78bHh32OgGxVad2it2IdbjSTHk8zOSRVBh3P1a9YHYV5TT dgPChk+5AqQV8G3B7nAFauHklvKmdTE3TvKidvf22LSqJFwIcB83eY2zaz8hLNXEu9LT JiJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=q4OERoBCD7W5Imf4FpoS99Di0FFY2nvnA28DUAkntGs=; b=fFcJ44rdWTkE36rDSm3vi86exz5fcYKZXCWhKpXIjbSfnxT5tgPd5Uk/N9C+Huz57J FJxkVOfMu62YePzceTJx/rOkaR82L1i5M0g+Alwu9tR1cn+Y9/8+ig7B0V/wIRg2LnWx /8OlnnTgMM1cYRfI4hhFx60XZvLb6VUt3DBg/ZO64gwCGqisGOwJcW0zrM4j0Du89+h/ KFErRYq28oL7OJlMpvtHg5Sh+uXwWo2GnadatSfot3xpcqC8cceuuRBx7ux/fiX5NtKx 7kRZKv0u+vSGfVyBsHzzHqzqbz6g8Y9oWGIlN85pnS9Ulk7dFLNTvYy8ktnyBd37BOPD 0zRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp12si3376282ejc.140.2021.06.30.10.19.58; Wed, 30 Jun 2021 10:20:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232597AbhF3RVT (ORCPT + 99 others); Wed, 30 Jun 2021 13:21:19 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:42286 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232586AbhF3RVS (ORCPT ); Wed, 30 Jun 2021 13:21:18 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15UHIgcQ024107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Jun 2021 13:18:42 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 3F26B15C3C8E; Wed, 30 Jun 2021 13:18:42 -0400 (EDT) Date: Wed, 30 Jun 2021 13:18:42 -0400 From: "Theodore Ts'o" To: "Darrick J. Wong" Cc: Ritesh Harjani , fstests@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 5/9] generic/031: Fix the test case for 64k blocksize config Message-ID: References: <20210630155001.GA13743@locust> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630155001.GA13743@locust> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 30, 2021 at 08:50:01AM -0700, Darrick J. Wong wrote: > > +# fcollapse need offset and len to be multiple of blocksize for filesystems > > +# hence make this test work with 64k blocksize as well. > ... > > What if the blocksize is 32k? ... or 8k? or 16k? (which might be more likely) How bout if we change the offsets and lengths in the test so they are all multiples of 64k, and adjusting 31.out appropriately? That will allow the test to work for block sizes up to 64k without needing to having a special case for 031.out.64k. I don't know of architectures with a page size > 64k (yet), so this should hold us for a while. - Ted