Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1727381pxv; Fri, 2 Jul 2021 10:37:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQMWDsi+1pjmrD6AGmRXs9/NaW64fSrECAglfb1387m9M0xUCF3NBUc3RINHokWm5gIJ+l X-Received: by 2002:a17:906:a18b:: with SMTP id s11mr954708ejy.8.1625247465736; Fri, 02 Jul 2021 10:37:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625247465; cv=none; d=google.com; s=arc-20160816; b=cnXUvZ63yAZv8QYZal7ihn1SDEYpuNx1n7YUoWlVK60kdvRym+/w8IzbtVdWM74pdM 2a6Z04coII96ikIJ8z/58Xd1zRFdxS3cEKl6TkUIBaiK7xbyFGOCo6RjIOLpidL0fw4T U2dyxOXPp8GePjYGRbWNAXWbOu04cYK45nRtqYi2i2ZhguXyjPf7FlXSCSJ2IsfUxpBL IJ+i9MVoHNwqXVJYbVTeoflHwGOUvaPl6UV06kwMaFqkraNKw6KmkGH9X8GDbaM5vl00 pab3ErbemayYHomreUkcryXWucdOiVHNVs9/pqq72iciT3tToBIFLOxfWc+EMLYTdcVg 3/+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=d/2d0CZbCYk5VZ0+C8M9elAUjYDkrKLNUqEX+ddF1E0=; b=aOm4LBW+sWk6Y+hqXMWPSaxjoGldnWiktPZA/6kQV4u+A/zZqawLnol8S4GjccB/rm zDyVNIzVGyyI/NV/u4e5c5QJES1fP9eclAmVJyNRdO6DSedwWtwwI7RTXGrEk5S0yWvB HzHkO24htgpgDbwuN9p209HJM/69x+02nQ6i8HDeKhtIGpqFTKoPlFl2dA3vEyHvpR/J 3wmM+0UGbYm5QlmOD89Xluflr83qGcpc60Aj1PQpJ4M7c9prtf7HWuLYvX3lRH2dwb1Y U7AFiFgDd4kauN0/S7Cn7wXnD09/xzyWjO6Seh9LXa1SgmIpXO7oa7M6LPqBNCfRDGZc pcSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id em20si4048962ejc.0.2021.07.02.10.37.07; Fri, 02 Jul 2021 10:37:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229499AbhGBRhE (ORCPT + 99 others); Fri, 2 Jul 2021 13:37:04 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:41545 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229455AbhGBRhE (ORCPT ); Fri, 2 Jul 2021 13:37:04 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 162HYRPD026119 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Jul 2021 13:34:28 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 6A7EA15C3CE4; Fri, 2 Jul 2021 13:34:27 -0400 (EDT) From: "Theodore Ts'o" To: Ext4 Developers List Cc: "Theodore Ts'o" , Leah Rumancik Subject: [PATCH] ext4: fix flags validity checking for EXT4_IOC_CHECKPOINT Date: Fri, 2 Jul 2021 13:34:25 -0400 Message-Id: <20210702173425.1276158-1-tytso@mit.edu> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Use the correct bitmask when checking for any not-yet-supported flags. Fixes: 351a0a3fbc35 ("ext4: add ioctl EXT4_IOC_CHECKPOINT") Signed-off-by: Theodore Ts'o Cc: Leah Rumancik --- fs/ext4/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 5730aeca563c..6eed6170aded 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -823,7 +823,7 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg) if (!EXT4_SB(sb)->s_journal) return -ENODEV; - if (flags & ~JBD2_JOURNAL_FLUSH_VALID) + if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID) return -EINVAL; q = bdev_get_queue(EXT4_SB(sb)->s_journal->j_dev); -- 2.31.0