Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4219851pxv; Mon, 5 Jul 2021 17:29:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhVZHvla+Ump9V4f1OCX5ME/XZrDvC9GXVzg0ELHaxjtdXbVRAzw4PD1zDYciutKZ1VBOM X-Received: by 2002:a92:200b:: with SMTP id j11mr12647715ile.183.1625531387034; Mon, 05 Jul 2021 17:29:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625531387; cv=none; d=google.com; s=arc-20160816; b=V31gP1oV61jIQ2gDGKMFzxUw9TbWXVfrfZ/VN1cgdl9ZtGDv87WYGYcD+eZ1vMepy1 xcdIb8R9id4SCZ+oS0zhWqqGepDPqV0s+EULghpDjoBiek41ofOyRMigtukI3D2ELcZv zFQS/YVrXdvIjaHKPr8CydnSusW8YUlREv3aPPGFwJhZ4Stu9bnhpBvwR8TLRMkUlRs8 jV3A41RVjlF02Gv0dhP8TDVfuh0P1cxam0eqIYphjndo5y9KFaWaxHzJaBJqnVmK4J7Z d+8Y3lTOSy1JxSFF/q6UeIw0xRxUiz8HtnQZe9t/RO7WQHMrY10MHGmikaQViLo2bydH KHyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=u3i4IC8eKdNYFftPWVdaalVcib8N3P0H/2R5a0XvlI8=; b=UmS3KNSMV2b0XwtieLG4WEnONtSjT3+p6enPD0N4FOlYtDljYNbEggOwB0vEEF82Lf IZ62F5kpG2PBQeFxilWUQjkORPpA1yYWLr2UUVC5KXoUUpMqPaRF40gzJVXjy2CkLJJP S5WhtLkb5IvUJPOOQcppqnsjBa3PB8M1x31AMZUZrnHbdA0NsAjNCzkL6wYt8kIzXmvT LAPs0/5JuETXqCj3ZcXf4nACeAvepz4hFSC/qwZiUVaRAe7kv7d8hUy4rmZJW+iljQRe kT18g9O3FWtEWq7xtIhcwheOdQe9Pc/IJ4LA7KU17pv9V8tXe/wW26+844QTXkKEYb5M jbiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si14699948ilc.117.2021.07.05.17.29.02; Mon, 05 Jul 2021 17:29:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229729AbhGFAbh (ORCPT + 99 others); Mon, 5 Jul 2021 20:31:37 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:47434 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229722AbhGFAbh (ORCPT ); Mon, 5 Jul 2021 20:31:37 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1660SsuN005735 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Jul 2021 20:28:54 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 365A015C3C96; Mon, 5 Jul 2021 20:28:54 -0400 (EDT) Date: Mon, 5 Jul 2021 20:28:54 -0400 From: "Theodore Ts'o" To: Michael Forney Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/2] libext2fs: use statement-expression for container_of only on GNU-compatible compilers Message-ID: References: <20210414074128.31268-1-mforney@mforney.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414074128.31268-1-mforney@mforney.org> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Apr 14, 2021 at 12:41:27AM -0700, Michael Forney wrote: > Functionally, the statement-expression is not necessary here; it > just gives a bit of type-safety to make sure the pointer really > does have a compatible type with the specified member of the struct. > > When statement expressions are not available, we can just use a > portable fallback macro that skips this member type check. > > Signed-off-by: Michael Forney Applied, thanks. - Ted