Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4295718pxv; Mon, 5 Jul 2021 19:56:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmuA41G3x9DLQQWSPRuB8SBMcA5zrTxAH2SkZYYC4P4lLtoucSwU0prJ3XmdQszKd91+rc X-Received: by 2002:a92:d406:: with SMTP id q6mr11552739ilm.23.1625540163915; Mon, 05 Jul 2021 19:56:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625540163; cv=none; d=google.com; s=arc-20160816; b=n54PwDJHgUZ4R9wXmgA/Q7PhegOVCw7NhgzFJ61K5LFp44qJQy/NBro4vHLbCWOomo SMusSguXfOwK2W/A2nHg6zYN5BTcGM79reJL9EIVRLYvl/dZ3+9nXIp/kEc1O4SmMjeo 34QY5KOrPZbgH9EGE7vQ9+dXVfnuG6/BMVYkEGkYgVhMLgiMmbyOxANkcomRaiGxL7+j efs6pFyZmU1ik/LizATpF6qgWtiYW3YlFHPV0i/nTbNcs2BgjynJfd4s5VVdqAbSGaPf oR/Pier5cnO9xr2cf3M0UAC7LfMRKjleI30ke2brv+BuDtoA2qhWGMUxbDmBji5NGyfw kP2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=piWcKIBROQFhahbH4Vpx+X5JYGpmEXJA1w81jtCRLq4=; b=tX01zW98cqk7bEMEqXC5Yit0NxqxLiVKqOnXNGCJ9+SUXN0VLjR9g/VwlEdHMkOkxP DiJ7Wjj6k3gSl7isU1o6xALkz5GWR4zM74KPKxFa3VpjJcduc6Ebuyj8KOYCzAjBr3w0 +KAheFLRqJWRHECC8dbr2zlyqCEJ6I5l8aYJRqovyJEQPuv7vgbBJNyI+nsb64AAWDMD h90cvWGkW0GErPB+S6Wcd6owTR7yP3ARuD852YriPXwH9sFDDezle06PwlvEsHCeC1K3 eWFKXzCl3/61smpD45ANK0AlfhUEni1dP4JRFXkS01xomkuQYZ3geDWBwfvaI1ak4tcc 9eaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j20si15832398ilo.0.2021.07.05.19.55.48; Mon, 05 Jul 2021 19:56:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbhGFC6J (ORCPT + 99 others); Mon, 5 Jul 2021 22:58:09 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:36490 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229827AbhGFC6G (ORCPT ); Mon, 5 Jul 2021 22:58:06 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1662tOpw018986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Jul 2021 22:55:25 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id A2FBF15C3C96; Mon, 5 Jul 2021 22:55:24 -0400 (EDT) Date: Mon, 5 Jul 2021 22:55:24 -0400 From: "Theodore Ts'o" To: Michael Forney Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 2/2] libext2fs: use offsetof() from stddef.h Message-ID: References: <20210414074128.31268-1-mforney@mforney.org> <20210414074128.31268-2-mforney@mforney.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414074128.31268-2-mforney@mforney.org> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Apr 14, 2021 at 12:41:28AM -0700, Michael Forney wrote: > offsetof is a standard C feature available from stddef.h, going > back all the way to ANSI C. > > Signed-off-by: Michael Forney Thanks, applied. > Perhaps there is some reason to prefer compiler builtins over libc > that I'm not seeing? It's because I pulled container_of from the kernel, and the kernel header files has to provide offsetof since we don't use the standard header files --- and it has to work across a bunch of compilers and architectures. - Ted