Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 6 Jul 2021 16:19:51 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Andreas Dilger <adilger@whamcloud.com>
Cc:     linux-ext4@vger.kernel.org,
        Artem Blagodarenko <artem.blagodarenko@hpe.com>
Subject: Re: [PATCH] e2fsck: fix ".." more gracefully if possible
Message-ID: <YOS655NZ3MnautMX@mit.edu>
References: <20210531233123.16095-1-adilger@whamcloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210531233123.16095-1-adilger@whamcloud.com>
Precedence: bulk

On Mon, May 31, 2021 at 05:31:23PM -0600, Andreas Dilger wrote:
> If the "." entry is corrupted, it will be reset in check_dot().
> It is possible that the ".." entry can be recovered from the
> directory block instead of also resetting it immediately.  If
> it appears that there is a valid ".." entry in the block, allow
> that to be used, and let check_dotdot() verify the dirent itself.
> 
> When resetting the "." and ".." entries, use EXT2_FT_DIR as the
> file type instead of EXT2_FT_UNKNOWN for the very common case of
> filesystems with the "filetype" feature, to avoid later problems
> that can be easily avoided.  This can't always be done, even if
> filesystems without "filetype" are totally obsolete, because many
> old test images do not have this feature enabled.
> 
> Fixup affected tests using the new "repair-test" script that
> updates the expect.[12] files from $test.[12].log for the given
> tests and re-runs the test to ensure it now passes.
> 
> Signed-off-by: Andreas dilger <adilger@whamcloud.com>
> Reviewed-by: Artem Blagodarenko <artem.blagodarenko@hpe.com>
> Lustre-bug-Id: https://jira.whamcloud.com/browse/LU-14710
> Change-Id: Ia5e579bcf31a9d9ee260d5640de6dbdb60514823
> Reviewed-on: https://review.whamcloud.com/43858

Applied, thanks.

					- Ted