Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp5159224pxv; Tue, 6 Jul 2021 19:29:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnJyPAzCp4LpfnHMn//LSQbmDr4OwOYJI7KBlspxy2PKIZ2oaddThAUe2VgQqfFrYGvm2V X-Received: by 2002:a92:c651:: with SMTP id 17mr16516656ill.44.1625624953400; Tue, 06 Jul 2021 19:29:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625624953; cv=none; d=google.com; s=arc-20160816; b=hoSJnPzWb4DfMrT8n2mRzFsuR4NHeGOCYxVeubp5y1RtlBSBa5pamxtrUJgcpvQNd/ L2EMg4F/+BCYXDjfeO4HmZFWWehpSjEmCgrojrwaMBhuMm7F4o4Sd2gYwxWUjmdBsL8e MVjcm3+h0pSiPpn9ORdugEL1gCSoA+RSU4kn5I2EUIMnGeMl+MlC9SQkG5ZJdZzM8DCP jxBqx/UCPZARgnoKawvcQvHwKQ86EkfHUxESoWpNKpwFYhUuHMr4oSxvf/mJMeDEg3Yt AV/HfNPT/ko+iaLgSL3P69qd2mU8DWn/J4v03Juts/yqgna/H1I3XKsrtLEXUwlP+a9G /1rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=8EASgdlDLFZkNIZ5Pv2mzOvwDSgwLXX45i3cMr1H7Yo=; b=IDiwTviqTZpIs4LK5dLaW2CFltD7G3/W6Ds6xo1rskOjIf2DxJSihNeG2XbGIy8Rbo J3e7gm1BRzquK5JzDqzXbu9cdD7feA5TYnkwr+otfL8U1TVEyHlRX0j1TXAV6ecgRVUh 7vKQQbkGRtr1ztmr8Qd6EzKz8Jsq/mHjoiBOo6yXd0T0emzM/+yih/VavVXL+YtC/X1k NCbUhywbfEtyZ7Ekc4eJTCYJWLp01EgKtwGHFz9YFdQTi84g27R8iBHAShUMI/f/V6hL jf5DQCXv+fAJiOMjTFwah2rnylaEnQtennUZyX/Z0k33In8cg+cDvWoMW6IYFFsZk7oP 88Aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n19si8104987jaj.117.2021.07.06.19.28.47; Tue, 06 Jul 2021 19:29:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbhGGCbX (ORCPT + 99 others); Tue, 6 Jul 2021 22:31:23 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:44056 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229894AbhGGCbX (ORCPT ); Tue, 6 Jul 2021 22:31:23 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1672Scb3024433 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 6 Jul 2021 22:28:39 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id A451315C3CC6; Tue, 6 Jul 2021 22:28:38 -0400 (EDT) Date: Tue, 6 Jul 2021 22:28:38 -0400 From: "Theodore Ts'o" To: Jan Kara Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH] tune2fs: Update overhead when toggling journal feature Message-ID: References: <20210614212830.20207-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614212830.20207-1-jack@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jun 14, 2021 at 11:28:30PM +0200, Jan Kara wrote: > When adding or removing journal from a filesystem, we also need to add / > remove journal blocks from overhead stored in the superblock. Otherwise > total number of blocks in the filesystem as reported by statfs(2) need > not match reality and could lead to odd results like negative number of > used blocks reported by df(1). > > Signed-off-by: Jan Kara Applied thanks. - Ted