Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp5167357pxv; Tue, 6 Jul 2021 19:44:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6cCOoZXoBDjydaXznVFAo7P/m5XQwZjrbJij4WMGVk3fW/0UqGqp8eY6u1GV3qgAC8czO X-Received: by 2002:a17:907:968a:: with SMTP id hd10mr10900476ejc.393.1625625865669; Tue, 06 Jul 2021 19:44:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625625865; cv=none; d=google.com; s=arc-20160816; b=lRveotI6ZvzcwE4cn9eubWHgkMvBGUo4bGC7UdMOQL8xkMmbc5jJO7ITXf5zeI1+2e W5Uad24IQzSZwcLGvN3gbVvkQ4edcJCvmifPpfsQNc/UXZM1ovWHdBlhfDkQ8uOJwfcV 2I48kTm1NaeXM+t/eVYGegxFbXDOXXsvjeFsirrmu5HD+JAuloSeLBcvDM90DwtMryqy /ubHfYbfkfE6KRcvMIj7JlduYedvBT/TEc2lANI0dRkr8DmbAaAfU/UEYZFbRZ0dMcgm 0HHJydhiWgMfaHYEMTC5J6ZmncbeKS+fk2fULLhafk14QRLLtAZmz6zkUMTe6uelwrsT kBGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=k9wjTuqS/fZ9JNm35BB/So+hnqTxBKMR0Vheo5e3dqc=; b=ChPcpd4JA99q4NFVCAlj8Tnaj5uRnvCP09GJ0s4pw7JW0SRbCy5tFphQuIb+FpTkDW SQBu2IemvJyyYA7V/MmuiI3F9ihkm5rYlou12AMfUB8c1UPpgHIE9K7w+LXojVbwMYsm NhR76Khgss2G33L8qS3rs9rkkGoiTWecAzemhD8car+kvvwxY7vZxroBXuD5AVfjLn4o n5c0GyeSmT0iIZYDhItkuoSWvle4d/sUt3tJ6A7N2w/TJ8XR8sfebhkBkezQWyv6y9Cm 3yAc2PqiBNNRJJz1AZxP/fPMinc58Cp3MNEXQqUsIfCf7uvM3VEYYbO3nR/jQPy6WXma Y9hA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hq31si9287345ejc.582.2021.07.06.19.44.02; Tue, 06 Jul 2021 19:44:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbhGGCqX (ORCPT + 99 others); Tue, 6 Jul 2021 22:46:23 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:45768 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229894AbhGGCqX (ORCPT ); Tue, 6 Jul 2021 22:46:23 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1672hdW1028770 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 6 Jul 2021 22:43:40 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id D48D815C3CC6; Tue, 6 Jul 2021 22:43:39 -0400 (EDT) Date: Tue, 6 Jul 2021 22:43:39 -0400 From: "Theodore Ts'o" To: Eric Biggers Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 3/6] mke2fs: use ext2fs_get_device_size2() on all platforms Message-ID: References: <20210616045334.1655288-1-ebiggers@kernel.org> <20210616045334.1655288-4-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210616045334.1655288-4-ebiggers@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jun 15, 2021 at 09:53:31PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Since commit e8c858047be6 ("libext2fs: fix build issue for on > Windows/Cygwin systems"), ext2fs_get_device_size2() is available in > Windows builds of libext2fs. So there is no need for mke2fs to call > ext2fs_get_device_size() instead. > > This fixes a -Wincompatible-pointer-types warning because > ext2fs_get_device_size() was being passed a 'blk64_t *', but it expected > a 'blk_t *'. > > Signed-off-by: Eric Biggers Applied, thanks. - Ted