Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp92401pxv; Tue, 13 Jul 2021 22:52:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcQX1gqX+5JCWrVdifkSbIS1IV/EMgoRpMcmpJNuIMijFgKIsZ1MJcoErgwFJF947Tyoje X-Received: by 2002:a5e:d512:: with SMTP id e18mr6006362iom.149.1626241968777; Tue, 13 Jul 2021 22:52:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626241968; cv=none; d=google.com; s=arc-20160816; b=kiG/gVT75YVge35dhvLpaYpaAuK0Ur611qPV78ScY2D6zZ/YP5BTNHFkTRxqztLlX+ sLzYNeb0KDPMwu0XdQ861WqNP7Nq3cICNdMGL00zd0UBB9Jy1UWD1YMREemBfYri3Qqm qNFKPKicwJoY7rJA1ThSMzAvy0TikjXkQA6FTLM4ZgGNYtSjHDLhsUrp5m2xRWGVtc4h GHVFh8YyriPl0km2opRpynea2ZZRbQfltJrHxP6jubOJiAjHHknATaImQYyAwkql/eok PYYGN5UcHGAa0PvfHOR8m9GvdBCjOY55dbQcr2ypROwtZQhW8PmcVkc6xh/GCFUJLA1x C0AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:date:message-id:from:references:cc:to :dkim-signature:subject; bh=oIQ4YoRp8NWzczGA6zi8tL8GAqZGGjIa0ixVNDfvEFM=; b=rWogWH0Yf1+jQZGOZS2rfsbAlR5/kz6JY+2AiXHM9ID6bp1qhaFZgN/Y0CjIQOfndD d3+C2/b7QSY3/xQVIgi+/NGI33x75kkFikjTxg4xhqHGke1rdywPdORUcGknpGH4XPD3 cHV+NYeszdXUlq1GyNVblOUD/GP/u3GxpoUQhrVMljbzwGVdjQydW+/9ZsKKnl1YRt6d tUUbPhJR/an+X+JNAqkANcBg3WmvuV7Xu0k6QeaGz+z23ZQmxfQ8cOYfx0p4RvziJ94B BskkBU01sx90M9SMcJWKJiE+RQ+BXME+2XAgG4hB7fNtxnAz0azkHaJD+yS5S0ZWTvGZ HVdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=AXIumY0+; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b16si1288967ile.135.2021.07.13.22.52.29; Tue, 13 Jul 2021 22:52:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=AXIumY0+; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237991AbhGNFzH (ORCPT + 99 others); Wed, 14 Jul 2021 01:55:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238040AbhGNFzH (ORCPT ); Wed, 14 Jul 2021 01:55:07 -0400 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ED3FC061788 for ; Tue, 13 Jul 2021 22:52:14 -0700 (PDT) Subject: Re: [RFC PATCH] ext4: remove conflict comment from __ext4_forget DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1626241929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oIQ4YoRp8NWzczGA6zi8tL8GAqZGGjIa0ixVNDfvEFM=; b=AXIumY0+aO06S0v6yxOb0ibAe8A8uyVQI4x0HWHifz0uC9Cvxm0ZpYJavq2+2v2b41+SX4 i8I9usXYT+FOB+tv/CrrqTBu1hFuaanE17ObJpo401LgWcwgHO3hEG6CkKbYM0UhJdf3ej 96L2YxLPvAEauSDfN39jjv+yRBMmHh0= To: Jan Kara Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org References: <20210623085846.1059647-1-jgq516@gmail.com> <20210713151746.GD24271@quack2.suse.cz> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Guoqing Jiang Message-ID: <7c151f94-75af-1e8d-4e04-0dd2fdf43b24@linux.dev> Date: Wed, 14 Jul 2021 13:52:04 +0800 MIME-Version: 1.0 In-Reply-To: <20210713151746.GD24271@quack2.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: guoqing.jiang@linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 7/13/21 11:17 PM, Jan Kara wrote: > On Wed 23-06-21 16:58:46, Guoqing Jiang wrote: >> From: Guoqing Jiang >> >> We do a bforget and return for no journal case, so let's remove this >> conflict comment. >> >> Signed-off-by: Guoqing Jiang > Looks good. I agree the comment seems stale. Feel free to add: > > Reviewed-by: Jan Kara Thanks for your review! Will send an updated one with your Reviewed-by. BRs, Guoqing