Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp97376pxv; Tue, 13 Jul 2021 23:01:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6cg4mMcsg5qFScFqeDMR97eKX8MPd703j55wsswW64uq5xps9PIcyKz5UGBgO64MYJEJ1 X-Received: by 2002:a92:2805:: with SMTP id l5mr5458705ilf.242.1626242474145; Tue, 13 Jul 2021 23:01:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626242474; cv=none; d=google.com; s=arc-20160816; b=BvHWB0pcSDsGRNsPdvW/dmDiaVOig3b8SZrF6GMjsELNekczDyuXkyWeRt3GT636zQ gGyBuXsPDCm0z3fwUP1QHeYg4P5YUjKJbc3GDRW+XWkn9HdsB1ATI/XUjwDMQRR5prYT FzGAAql1+zZCHgsEDAkT4guuCC4mCqbyOwqmtdTnHXgmfTGzpzlcLYzWL9V1UZdSQBWH ABB+Gmeike7A9Dz3bnfQc/EANT36x/Kzy0yE0/5xB9iOCE+KIBzGjI7FzPhgH9jIe/ja W9ATskNYx5d4xNAtYYA/50tF+vbm1uCA7ZccikduevETultuzhXq3FDpbVsdOC+LaOaS E7cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vgFj1qhJhUzKaaf2VmU6hhsMPALVHBqq5tIRM5o9xPc=; b=gxoeuXXW/4HrDHO6eqE9JtSfw2j6drCQBNEyFnhI0mNmmsgjylctDNbTYpMfN4WoVO uB5TiJOdKD6ksdO2XbA+uxSHuisMLP44uxTGaWOZ3epGY6qqVSGc+Mq8g28MXlLCkbKg d6S3areYf03pz2MmmjIVshMefhwTojra08ly4ncI3+/hFJhfgdxkDUjwonb+ehtAsQVE 6vpziuchnYms/9Ya3/aF0QQO1vFvyhUXuf4672lRrND1pKIvzBOzFmao6qp89gasMsFH a1WUgvoO8l7SeKPe96WF26VX5fPVLjMYILEQUXd1/79F3rbHzSGmslDRZRGS56Ucmbgt 1hmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=jZ+vrzUD; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w4si1351074ilm.77.2021.07.13.23.00.58; Tue, 13 Jul 2021 23:01:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=jZ+vrzUD; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237946AbhGNGCz (ORCPT + 99 others); Wed, 14 Jul 2021 02:02:55 -0400 Received: from out0.migadu.com ([94.23.1.103]:42281 "EHLO out0.migadu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237921AbhGNGCz (ORCPT ); Wed, 14 Jul 2021 02:02:55 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1626242392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=vgFj1qhJhUzKaaf2VmU6hhsMPALVHBqq5tIRM5o9xPc=; b=jZ+vrzUDdoyzClatSmL01wP7aQs+Qm5x8vv7T1r/au2XN7zwbRpR8ejcc4Z1QwgMOlYcbg sxbHLjR9m3Ns1E5wIh50xGNWTAsGdrJtJ7+Ty6wlwxsQ4bBK6E3b+UwstoythbhbkpSEtu OJrLsCpApZ4GDNi0bELnBmxk4Pz1uTM= From: Guoqing Jiang To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org Subject: [PATCH] ext4: remove conflict comment from __ext4_forget Date: Wed, 14 Jul 2021 13:59:40 +0800 Message-Id: <20210714055940.1553705-1-guoqing.jiang@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: guoqing.jiang@linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Guoqing Jiang We do a bforget and return for no journal case, so let's remove this conflict comment. Reviewed-by: Jan Kara Signed-off-by: Guoqing Jiang --- Change from RFC: add Jan's Reviewed-by. fs/ext4/ext4_jbd2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c index be799040a415..6e224b19eae7 100644 --- a/fs/ext4/ext4_jbd2.c +++ b/fs/ext4/ext4_jbd2.c @@ -244,9 +244,6 @@ int __ext4_journal_get_write_access(const char *where, unsigned int line, * "bh" may be NULL: a metadata block may have been freed from memory * but there may still be a record of it in the journal, and that record * still needs to be revoked. - * - * If the handle isn't valid we're not journaling, but we still need to - * call into ext4_journal_revoke() to put the buffer head. */ int __ext4_forget(const char *where, unsigned int line, handle_t *handle, int is_metadata, struct inode *inode, -- 2.25.1