Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp932089pxv; Thu, 15 Jul 2021 20:20:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwx9B+s0DdUTgQKhqm322dIfnSWBQi4Jk2PY29uSKwp80+QIUPQkLSPDFvnKJK2pQzJNmUi X-Received: by 2002:aa7:de90:: with SMTP id j16mr11510951edv.385.1626405642045; Thu, 15 Jul 2021 20:20:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626405642; cv=none; d=google.com; s=arc-20160816; b=L5JB5Qtqb2l7d5Bg49Aw6Y2kRN78zBLCe8eeCEnzO1kwKGnii57UcISmiZDHGXlqoz uKZQ3krw0YuoIxFF2H2XvHrzLyYm1phqfCE9HN8fUizYxz+6xxfy9meB2S0j5bGTv48E G4r63kg0AswF9UvvzzScyKGDJzV8/fsv7j6bpbzE8iqwtEzgP/tdOgGND09jWEebnuR4 aSkHwzd18KWGFX8vc2P3n68MQNsZLwIOg0cbgkh0wHJp2ycAlheGJUjRmMiax3Mlxl0e O5sZKjWmeGn0iXfImo2IzbvO35T2aRDRrF1LFO+iACGGu7Xfb3JzRW0mDr0OCwpgpD/d 8ITg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=3g3hXPKdWSCX+sZ/EU/XK3xvC60YZv/Vibirx387U3U=; b=QKGyb94xtcvkhKNqtn3ceDMlV9tKcd13kOTxzWXh1swnNbcR99M1dO2UlCeuqaax9d JtZjQ+ApSpsQgOa0EoPKZoIWq9Eam03RPPww8gCAJAfsksKwWFiNnn9QdhmUH9HNGtXS aybFditzleF65g3K8Erw4IJkwfrz3tRYc+9ijMDZhilh49zrAjLlOdS2oKslx8i6gUBc oyp4jMDvSJJG2iChdMWaIj/xyLvtezKBugSRuhxAUIwH6LnFB59tno91uKQNPlKSVPOs lUsj6Cj0S6KJGbMGLojCh5imXkmvj2dEtl/BjHFBjo9eshQGUMlhaxJdTBaMOQiUxrru iYqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 27si9027406eja.1.2021.07.15.20.20.18; Thu, 15 Jul 2021 20:20:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233702AbhGPDW4 (ORCPT + 99 others); Thu, 15 Jul 2021 23:22:56 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:36567 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233550AbhGPDW4 (ORCPT ); Thu, 15 Jul 2021 23:22:56 -0400 Received: from callcc.thunk.org (96-65-121-81-static.hfc.comcastbusiness.net [96.65.121.81]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 16G3Je7v018383 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jul 2021 23:19:41 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 598E34202F5; Thu, 15 Jul 2021 23:19:40 -0400 (EDT) Date: Thu, 15 Jul 2021 23:19:40 -0400 From: "Theodore Y. Ts'o" To: wuguanghao Cc: linux-ext4@vger.kernel.org, artem.blagodarenko@gmail.com, liuzhiqiang26@huawei.com, linfeilong@huawei.com Subject: Re: [PATCH v2 02/12] tdb_transaction_recover: fix memory leak Message-ID: References: <20210630082724.50838-2-wuguanghao3@huawei.com> <20210630082724.50838-3-wuguanghao3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630082724.50838-3-wuguanghao3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 30, 2021 at 04:27:14PM +0800, wuguanghao wrote: > In tdb_transaction_recover(), need free data before return, > otherwise it will cause memory leak. > > Signed-off-by: Wu Guanghao > Signed-off-by: Zhiqiang Liu > Reviewed-by: Wu Bo Thanks, applied. - Ted