Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp943274pxv; Thu, 15 Jul 2021 20:41:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoHccJvFX5Uiqtw1Jd7Hqu38mz2BqxxXAhClq47z9uO5sqYithNSktXVPNR1rED6AZndGp X-Received: by 2002:aa7:d143:: with SMTP id r3mr11655850edo.110.1626406918384; Thu, 15 Jul 2021 20:41:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626406918; cv=none; d=google.com; s=arc-20160816; b=DHjNsuSQek+7vK0XWc6QCt9WQfFSruzb1CiBZQD+Z+BJtLFgcWv6J5Ouq1LwHa3L/Z P1kDVaeH4rUAmyUnDIlH00Iod1oEdcvAYItlv0ITVVnS1Lra+kNKl8eaYpOw2EAwLYyP u4hZsQlG6byUcSxbttHl7COAkNS6wZNVl0KUNXsZOw2TE1nCoCBpT9GS0NIChcoGMV/x KAeu902aylhxEUEWtdwBo9I5JzkWYNtUluJpk/WwRqaqdL9VSYk3t3sp5Us6pzUCcx8k SXz4ydR6jpmvYsrw9yE7vBY3Aa01DlwVWS8iLvOI94PEHMYZ6UAT++c1OJ2XH+XAILyi FjDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=HQBToLI1bJln16ApY7INJaWHOLi0uND3gFyYBIExd8s=; b=yR2OtorHx1i0b02mf6miWVYqRwwG4qIArbAz+mDPp06tyoZKBNiJqNDG2lCl+z6rnD rGOcXkdgCCTy+r9uMYlhrNSae0+x1SNm4pY2bZz+2R5Kt7iQK+tpMNJEXtLrj0oSU1n2 1celoz0+cucLwv68Q0SCI8wBSQNMao6XTxN1wQvx/yBQ/LYH8jFu2GLYXp/FuQlp45PR QuSaBIDY6NG+iPT0xeqspZZYsOg6BpNjcsGCcfc0FVGiVbMLph6bNvK0iSkWf50gypP4 OZO8qkq4IMrr10u0718KQYOXzcf7xZ/FrsJH80McqF8L2kY3wxeEF1+7rwoC3Uq/Hl04 hlAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w13si10688576edx.361.2021.07.15.20.41.34; Thu, 15 Jul 2021 20:41:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231481AbhGPDmM (ORCPT + 99 others); Thu, 15 Jul 2021 23:42:12 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:38166 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231230AbhGPDmM (ORCPT ); Thu, 15 Jul 2021 23:42:12 -0400 Received: from callcc.thunk.org (96-65-121-81-static.hfc.comcastbusiness.net [96.65.121.81]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 16G3d5EB023590 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jul 2021 23:39:06 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 488DB4202F5; Thu, 15 Jul 2021 23:39:05 -0400 (EDT) Date: Thu, 15 Jul 2021 23:39:05 -0400 From: "Theodore Y. Ts'o" To: wuguanghao Cc: linux-ext4@vger.kernel.org, artem.blagodarenko@gmail.com, liuzhiqiang26@huawei.com, linfeilong@huawei.com Subject: Re: [PATCH v2 06/12] append_pathname: check the value returned by realloc Message-ID: References: <20210630082724.50838-2-wuguanghao3@huawei.com> <20210630082724.50838-7-wuguanghao3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630082724.50838-7-wuguanghao3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 30, 2021 at 04:27:18PM +0800, wuguanghao wrote: > In append_pathname(), we need to add a new path to save the value returned by realloc, > otherwise the name->path may be NULL, causing segfault > > Signed-off-by: Wu Guanghao > Signed-off-by: Zhiqiang Liu Thanks, applied, with a minor whitespace fixup, and the commit description linewrapped. - Ted