Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp943497pxv; Thu, 15 Jul 2021 20:42:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwximvyYMja0QrmcZkReccInV9nQzc1/yTrfHoOedziTUez0z0qvUpY/9wyFZZJAiFG5adK X-Received: by 2002:a02:c95a:: with SMTP id u26mr7077039jao.49.1626406942398; Thu, 15 Jul 2021 20:42:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626406942; cv=none; d=google.com; s=arc-20160816; b=DuwhrZ+F9ZqA00/OGgo6q5HSj0sAst97OGIQ1J8ykNC7cM/Sm98cpkX/Wz4TdoyYNf 9jtVwHhY1i2RLzfT0igu99b9h/t7jRgjnL/nLWztToxvPG1D4HRQsMALs8lXb4ypWFAZ L2UlBZUa6ZnLHple/RJxCBGNiaBg6duCxxr7AmO1FN/lFhq93f8PKWjBb4xyya1FLMfM KOqDXPiyKO82/rwBlzv4kumoZxDYI9sqGL3PN1hKI8038IBMbc7A5w+ns+rN00zmm9vp IPUpz0dMrcU9lI3U0SKBAIZD+kCX4KscGAd0CxVvdc4PvK0qq01E/rFkd+4qhdQAh8CI gGCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ZmGYyl6+LPL5eAiQExc0zCWhbBpXJ1Csv4asjZofgjI=; b=ttxYzH4X1M0qvfocoygy/lGOqKFwqr6SHffz7WX5ZNX5iXcxYRIOW7vBSyR0TypkT+ mWDOfrpQOpC/t8R2qEZG15zW5vo1qRCm2WJ1AeHMJDf9XWjrFw0wHuYyLX7OR8w5cbrd HpuNbaQN0XHpzPd/3CeNmghAm8rMSWUWuOaMPdCeR+CLsQNQsYEb9caaBGehwLHq+QZ+ Ig+qrTSnDmdRYZnrM7KYbRvhocOYHkMzuoJHbEFvy0XzaPJF1EQaTXnfH/auuzakqpR4 p/nS/bnPymwsTrlHHfx2im/lT3+0CnTbP/OrGLJqbymuJg7sB1eKAaZnnzonMw61T8tk JBrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d198si9180011jac.70.2021.07.15.20.42.10; Thu, 15 Jul 2021 20:42:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233822AbhGPDol (ORCPT + 99 others); Thu, 15 Jul 2021 23:44:41 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:38389 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231230AbhGPDok (ORCPT ); Thu, 15 Jul 2021 23:44:40 -0400 Received: from callcc.thunk.org (96-65-121-81-static.hfc.comcastbusiness.net [96.65.121.81]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 16G3fbgb024271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jul 2021 23:41:38 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 88AD54202F5; Thu, 15 Jul 2021 23:41:37 -0400 (EDT) Date: Thu, 15 Jul 2021 23:41:37 -0400 From: "Theodore Y. Ts'o" To: wuguanghao Cc: linux-ext4@vger.kernel.org, artem.blagodarenko@gmail.com, liuzhiqiang26@huawei.com, linfeilong@huawei.com Subject: Re: [PATCH v2 07/12] argv_parse: check return value of malloc in argv_parse() Message-ID: References: <20210630082724.50838-2-wuguanghao3@huawei.com> <20210630082724.50838-8-wuguanghao3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630082724.50838-8-wuguanghao3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 30, 2021 at 04:27:19PM +0800, wuguanghao wrote: > From: Zhiqiang Liu > > In argv_parse(), return value of malloc should be checked > whether it is NULL, otherwise, it may cause a segfault error. Thanks, applied. - Ted