Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp946359pxv; Thu, 15 Jul 2021 20:48:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPT8N/9W1NHehnz1BmEcjLlPeZrkE0wftznnuiEEinq5FdYDctXWHmutrUt6T3JNXj4u/6 X-Received: by 2002:a17:906:d1d1:: with SMTP id bs17mr9261801ejb.492.1626407292920; Thu, 15 Jul 2021 20:48:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626407292; cv=none; d=google.com; s=arc-20160816; b=J5xuXK2hXiVYuyvB2dMKUajnRSKDvhqK4Mf6eLy+XxpI5oephb+04cR29UoicGwLPJ S6af5thfWu74GG9Nvh7VNp/BETM+fMWCYMHzrhNirfBIGBqqSGYVSz4bmq+aYyDqdLf2 qrqvVVhvuL9xP7bXepERWcFXpdFXh8Nr3QieI1vMx0XUnqR65KmoTi0vHNIGDc+z67aG wPdchZqcbKQdWQ+/ay2RQXDEV5aUTzvHHymgy2cN+G7Bok0zA7PdHbnX+4rY4gaWVJ3o jsJfRWWLNEpugzyKQnjLRb278bGXO5SLlqMCkMTtV8zmbf3BhOG7A4LroWvrhcdE8FQV i6Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=4QO9Qd8WzfS721/GTKelCRYINXb8fxeOH5ytoSTV04c=; b=czAxvDD0CBkhAY6hTn/hVgJfJt6aMrczZ4AN997urPWppQruagADnTIKi/ra/7mj1G l0mMEM0oL7j2XUjFClmpaky454W4vCUtCAaZv+0a49AsVl+GvOyK7yHNBoXu1cZUuG+e 7f3xhwR/GWzE1EwIKPyaqZUQl75Mf959NZpzC6GTXDFIj2kZ8wvSMMYPonoarNbi1y1A 8ba01ZnqXfU9Hf/QRmqFr9zhuHNy/J25wcAkAfJJYZH0bjJt0bdSrzF/kIuBsnanDLZJ Xj3L3qEdTHXI+pLtqlZZn5JwsJfCWgLWRYZ2bQ9VZt04kIQqkZ/Mi4RP5Sqa/c+IKucQ nl7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 5si9658770ejl.332.2021.07.15.20.47.49; Thu, 15 Jul 2021 20:48:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233755AbhGPDua (ORCPT + 99 others); Thu, 15 Jul 2021 23:50:30 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:38889 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233726AbhGPDu3 (ORCPT ); Thu, 15 Jul 2021 23:50:29 -0400 Received: from callcc.thunk.org (96-65-121-81-static.hfc.comcastbusiness.net [96.65.121.81]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 16G3kYDM025653 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jul 2021 23:46:35 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id E7CE74202F5; Thu, 15 Jul 2021 23:46:33 -0400 (EDT) Date: Thu, 15 Jul 2021 23:46:33 -0400 From: "Theodore Y. Ts'o" To: wuguanghao Cc: linux-ext4@vger.kernel.org, artem.blagodarenko@gmail.com, liuzhiqiang26@huawei.com, linfeilong@huawei.com Subject: Re: [PATCH v2 09/12] lib/ss/error.c: check return value malloc in ss_name() Message-ID: References: <20210630082724.50838-2-wuguanghao3@huawei.com> <20210630082724.50838-10-wuguanghao3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630082724.50838-10-wuguanghao3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 30, 2021 at 04:27:21PM +0800, wuguanghao wrote: > From: Zhiqiang Liu > > In ss_name(), we should check return value of malloc(), > otherwise, it may cause a segmentation fault problem. Thanks, applied. - Ted