Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp952912pxv; Thu, 15 Jul 2021 21:00:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTizJCuIhS5kAuIOxposQs3q5iz0yE8v1fYC33lTMvRRzUrPzgZtk9plasyKSVM43vVc3x X-Received: by 2002:a17:906:d105:: with SMTP id b5mr9580152ejz.50.1626408045126; Thu, 15 Jul 2021 21:00:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626408045; cv=none; d=google.com; s=arc-20160816; b=ZMoq3EFZGCcGB68r43T5n3IRmUt1v76DrlFGxgV5pHqilchWHxexws0DbjQ5r9S/1b HUO5L7coaME76ME/3OPl9mA7vQ8YxQvEcod/60p4fzaZiWFIjEGb3ytR+0WoCTZhaqhf OVjVbTjfxw/qBYpUzX7X5NKUdg+PpgI6uv1JbY9keSvI0heOzHAVhxHxXUvgASiNqESa qyGdwT1/TzjI+tCkuHN6rMDvRB8srxkscnu+zZvZL74uE7jleaf2wI3a1EgZscoychSX T8qm3tJ9aBlhaZ0Xh0gIZ8wFi6zZKiWM6COjHmmALxDgB626ZrpYUeJ+Y3NRfDCBaPM4 +CrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=gP0eCLydgJ0kVRrxo4TmNwTof8vVaP4S25l5Eu8BxSI=; b=BfRipCkHkvumuJRdyZrQJ1Q3mXRY84tc06+mYHyGP1n7l6lKGra6ziCAQNtfZ6O6ut KaYQogjyqvyWh6GaGIRlHekqzPzkpBnWhnb7v23vbxbpvVRUT+Tz3KEz5A40f3zc5m8W 3YHOsRL0yhJwdv3fgGhNXuUr7u0Olbb7W/hh1vVBzqmkXZDqAvGJXztxyjw4z8D+3gDr d49f6N+iDa33wafmkFexFFi/yI9yrFQq1+nPlufc3JxJmOZy7HquehyUmh1lK0+rgtwU Z/42cUikg017yZ1wASzP9PImmpyeJ8VLt1DKChkiZOSzfn5uxAnsxK8y2E4o+yNLrUeN DhfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v18si9852136edr.159.2021.07.15.21.00.16; Thu, 15 Jul 2021 21:00:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229534AbhGPECq (ORCPT + 99 others); Fri, 16 Jul 2021 00:02:46 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:39915 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229507AbhGPECq (ORCPT ); Fri, 16 Jul 2021 00:02:46 -0400 Received: from callcc.thunk.org (96-65-121-81-static.hfc.comcastbusiness.net [96.65.121.81]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 16G3xcsf029039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jul 2021 23:59:39 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 3A4C14202F5; Thu, 15 Jul 2021 23:59:38 -0400 (EDT) Date: Thu, 15 Jul 2021 23:59:38 -0400 From: "Theodore Y. Ts'o" To: wuguanghao Cc: linux-ext4@vger.kernel.org, artem.blagodarenko@gmail.com, liuzhiqiang26@huawei.com, linfeilong@huawei.com Subject: Re: [PATCH v2 12/12] ext2ed: fix potential NULL pointer dereference in dupstr() Message-ID: References: <20210630082724.50838-2-wuguanghao3@huawei.com> <20210630082724.50838-13-wuguanghao3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630082724.50838-13-wuguanghao3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 30, 2021 at 04:27:24PM +0800, wuguanghao wrote: > From: Zhiqiang Liu > > In dupstr(), we should check return value of malloc(). Thanks, applied. - Ted