Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1457351pxv; Fri, 16 Jul 2021 09:44:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzM0B/yUj3CSa+y/V2++1iWdLNR0mWM9YzW/NtIywjjciAWpWxpnSsDt7J5JoHTB9QvA37h X-Received: by 2002:a05:6402:3d4:: with SMTP id t20mr15994509edw.274.1626453894208; Fri, 16 Jul 2021 09:44:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626453894; cv=none; d=google.com; s=arc-20160816; b=deYRXLovf9lJQ8s4VJavG6iNf+NWv9lqg6b+cPsdM14cnRfe+Qr0vDNhaQ71VUGLGQ FdErYNKRRlPUAOhx5t9hs774roVJoA2TW7HzxALcZrU04L37y524TrxkRoqqhZkYRJHc 9rl2ZoSOPSjSvQrys30qOkjgfGDgoU33OtOH5HdUIE6WfOOlLB9if3v459Gt9IxSiwT3 UlufBzmu0OBBFmq2g/7BYDKtatd08RhZ7KSj9f4A9FApjUOLfFD0NW3sYskjPMspviP5 Tk1yN7vkFhwzNEKAOOiMJJzz0j4dTSfRiZPnVMz/RPT8pOFb5IFnofWAwr/DUxHWayXb TtBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rWWf+zDwu+Do2QNiJySi0XD6nJzM4RK8fj9tnzDP+24=; b=k432982fw88dEpt+oMB6ho8sANSqG+/oaVlzZU8Lkii3Uy3p77KjE237aEeUp87yU8 l92OInENYNsP0WwG+7eE+KTDhn2zSKXGINxF/zRFJizxdQAaeIri2Rb+nUizp8E4cAFx qYhcyCkws8fux9l5h5GOXsO/M2ifC3fkDTVFqvsCOdzXBOQ2tWVdlu4KatJ4Yib3f8iw bFgIXAoMBjDiL6yBx1bSNvCzba4z2N8TwNCt9kibhihXvhUeV0sxPOvUO0E//j6eFrK0 EdLngxR7CLVIasJEO3w7qkrHctZDDYuH7X7zGJL7cBjCxOTMjKMIUlNOT0/W3QtCGgS0 LY6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ER33OScu; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si11312728ejh.74.2021.07.16.09.44.25; Fri, 16 Jul 2021 09:44:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ER33OScu; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230189AbhGPQqL (ORCPT + 99 others); Fri, 16 Jul 2021 12:46:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:47086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbhGPQqI (ORCPT ); Fri, 16 Jul 2021 12:46:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 35961613D0; Fri, 16 Jul 2021 16:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626453793; bh=4cf1AnF6M65jEKCZ4DUvlF+jXCvIQBpF34YgrerdDE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ER33OScu5jXxJL4bBbchkSb43icKDsitlTLzz/ULEuCKhDyvzfruACZnB7KEth/Ea CrHL2LSiOdJ48FNoGdUcRJPztvvlN2R9q/wJJKcgnB4F1BFPAddcRBz30NPyaVNVA/ c13g+u1kfK1sYm4jZTlXTgZiWA4uk6IRkbh//2Bk3gR4M1niUW7g70cN+zj01sKUw5 w11NLDR1ohyuzzNvoiRCItpM7Kwmua6Mzwh8IqK6FDO3uAqgbL4KU/TlVuM6lEEHgQ owdro4sa6g8ZVQZprvohZ8U0qKtbPZRfpQ+EtiAyzSrv0hMzf/nWGpv1wM1Qur2p+u KJcRDYSgBrojg== Date: Fri, 16 Jul 2021 09:43:11 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Ted Tso , Dave Chinner , Matthew Wilcox , linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org Subject: Re: [PATCH 0/14 v10] fs: Hole punch vs page cache filling races Message-ID: <20210716164311.GA22357@magnolia> References: <20210715133202.5975-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Jul 16, 2021 at 07:02:19AM +0100, Christoph Hellwig wrote: > On Thu, Jul 15, 2021 at 03:40:10PM +0200, Jan Kara wrote: > > Hello, > > > > here is another version of my patches to address races between hole punching > > and page cache filling functions for ext4 and other filesystems. The only > > change since the last time is a small cleanup applied to changes of > > filemap_fault() in patch 3/14 based on Christoph's & Darrick's feedback (thanks > > guys!). Darrick, Christoph, is the patch fine now? > > Looks fine to me. Me too. --D