Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 0/8] Support DEVICE_GENERIC memory in migrate_vma_*
To:     "Theodore Y. Ts'o" <tytso@mit.edu>
Cc:     Alex Sierra <alex.sierra@amd.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        hch@lst.de, jgg@nvidia.com, jglisse@redhat.com
References: <20210617151705.15367-1-alex.sierra@amd.com>
 <YM9NXrGlhdp0qb7S@mit.edu> <905418d1-9099-0ea8-a6e6-84cc8ef3d0b0@amd.com>
 <YPGgvNxfOCx/Sp0g@mit.edu>
From:   Felix Kuehling <felix.kuehling@amd.com>
Message-ID: <e9cc27d6-b0f2-8379-c276-0bbdae3ce4d7@amd.com>
Date:   Fri, 16 Jul 2021 18:14:05 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <YPGgvNxfOCx/Sp0g@mit.edu>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.2.100] (142.186.84.51) by YTOPR0101CA0033.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:15::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Fri, 16 Jul 2021 22:14:06 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7a64b23e-a7e4-4f3e-180a-08d948a7078a
X-MS-TrafficTypeDiagnostic: BN9PR12MB5292:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BN9PR12MB5292111CBB7DF654322B4BAE92119@BN9PR12MB5292.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: KTX+PGoNC7agqAp7YhVwHLo+MvK1Zc8PDvJ86dbpuyjCu1G0JdCK681HUX7YWyZpTVF86n/+y/GabqyGh5SFv5VmTw2X5/ElAG1KueOW8vP+L4T/6HZKJzjB/FzK9nvUEzW82jdkd36a9NByK7Xn/u5LnbLgjdfqLfZ2fQP+0mK4LubCFjdKW6zlVJEEzrhAHm5+gdW7hqlfNMTB472HwkeMr0c1o/tWWWvYaF0tAqDnwH+Qscc1LIZcl/I23dWz/k+v/UqeTIGPQQxUpADbfMie5BjtdV6pcZLf3iZVqCZt3OSQ3dt8O2a1hnxtf26A5iZEMkMROOFWmTabjVRxaX2rXf7EdDi+8bTfaIhv1NAQio1eAdUd6yH/BcrKLrnuJT6vakffgUmrehxALiAMRddyBLq5ZfgfqWqFaRdAEiMG1p+QEwhRzKBS6udoohVLtwL0y798ErQGLT55FCviObwv5MI606aB4irkd7O0KyQCpDdid0ZMyhDR4fOQNymRMZQuk/0JDF7RcnxnVGc6nCzTAUVOUOrD3nXjm2XG2wl469NWFxBBd/PkCHbm+rtXpGTsSCjCoo+eKqgel1epHN8khXXwqolkRcrrmO4tsaT341o9zBnZfA2rrrkWHpswptCQsLov2f8EYMS2CcXRdErOYISUahXMnaLogLQUIKL4LKaq3+/xRdLrK/SRk2xMdjzYHC80D21WXWTfV5qQqiEhgoyAJ77dP6+y0vcVfI8osqfOw8QnBDiJhWvTR/+7
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5129.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(186003)(26005)(38100700002)(316002)(5660300002)(4326008)(478600001)(31686004)(8936002)(31696002)(16576012)(6486002)(66946007)(8676002)(66476007)(36756003)(83380400001)(2906002)(7416002)(44832011)(956004)(66556008)(86362001)(2616005)(6916009)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3p0ODg0TlhMTlh6V0FzZVVsMW5rc0wyNFdUNDM5RE9rdnFYNGcxTjE3S0ZV?=
 =?utf-8?B?Q2EwRlNCeER4UzVFbzR3NnNCUWJXRzBRUkhPMU81QTV1dU1VZHRqK2VQaFJH?=
 =?utf-8?B?VTNheFRMWGJOMGVjRHdHKzRKV1FqM2pLeE5Fc1pLLzIvdm1wNnlMTUtqL2Zj?=
 =?utf-8?B?V2gzSTdLNk1HempiYStuaFJkdllyN0pWYXp0cWEwdUY1eEM3OGhrN0lNZmJI?=
 =?utf-8?B?QTRVQ0Z0YU8xN2lKSFZDNnlJZnlRMUpubWtmSnNyb29xdFBJT3FaNEEwZTM3?=
 =?utf-8?B?K2RzRk5qS25zbjJ2UCt5SGs4cWVnbW5UU3BoVnhXMVgwd3dVY2tpZ09NUzIv?=
 =?utf-8?B?Z1F5N2JUVEFCWEtzQUxyZ0pGdW5maVlGUS9rRFhDT1VQbm1wVlhiUitKdzR3?=
 =?utf-8?B?SkcraEFMd0RoNzJJRlNGemtGWkNPSVdVc0NIQ3BiRjRhdzFTaVord2dkM3R6?=
 =?utf-8?B?ZzBXMjU3RUxtTUJjanBtZkRyVlRUdVpvSkxPSkh1UnJ0ZzlHSmZtcEFWN2JH?=
 =?utf-8?B?ZFh3WnF5ajNrZmFac05kOU1mSjhhWC9CVDJVVGFpSGVGdHVCdmlPQnU1eHRK?=
 =?utf-8?B?VS9IZWtaUVBOQldaVEFFbTRsUHd2UlVQMWc0dVBUL1EvWVFMOVJxbnBqSitB?=
 =?utf-8?B?NnNGUWhFOERDRWhpTVJpZzRUNXVrMk5RU1NFbXdibjRLb1JNcjlLR0wvZTg2?=
 =?utf-8?B?REZlSC9QUHU2dkZUSm5KZm9McWFka2Q5ajk0eERFMmllZDNOLy9aUmI2YXVn?=
 =?utf-8?B?UjRYbGM0UTdoSGZvZ09Bc2czQjdqVUdXMlpJV3RHdVlGWGkyTUxaVVNOd29v?=
 =?utf-8?B?SVhZc0lzTlE1YTc5Y1dTY0x6UUcxSTR2cFRPam9DVEc2T3Fsam1WY3RQMTRV?=
 =?utf-8?B?SU1qUE0xdWVTdTNFTHhoWjZCcEZTaWc4cmNBYzREelVjNnh5OHpTU2JDU2lP?=
 =?utf-8?B?NGNqZDlVQjdWMWI1TmxVNEpqLzNQK3NGSHBpamdSQjE0MlgxYjQ0QU01R290?=
 =?utf-8?B?RVBOQkdKSDZFM1RuKzdjNmt0dCtGd082akF0Rkp1a2tyaWZDUDZ4N1p1YUY1?=
 =?utf-8?B?MzZlNkpyTFRuR3N3YzRveGZpWXNNOGN4NzJ3cnJ3ckoxVWZ2SVpQQ0FPeFFD?=
 =?utf-8?B?dEtlT281SjRqMVlPY2Vmdkk2eXIvY2JucGM2WDZTUzBhZDdycEp0UGcrTXVk?=
 =?utf-8?B?ZU91ZDJCelEvQ1ZxVFVvVE1rdWJlOUNkRnVzb1hPM2xOcFBZOXRoNGxPT0xM?=
 =?utf-8?B?cTdsakYyQ3dMWEJ1azVhSEh0dDJxcy9ZcW0vL2h0TmlTQ3BXOWgraEhuTUxQ?=
 =?utf-8?B?VTR4WkswTjllVDU2QUU4M0FZNmRKK1hhSHVkb1lIU1drUW1zQm9LcnJXK0Mx?=
 =?utf-8?B?cXo2KzQrRlJMcWFSdjU3NFpDcUlnUERqNm96M25qQ3RYYU1Hd0g3SGFkSG9U?=
 =?utf-8?B?R2phRjlUY2Z1eG9ZRUFnelhpNkxSc3hqWDg3ZEpNc2Y0RVlRa2RpZThkOEY1?=
 =?utf-8?B?ZDZackxyRHdFc0dYcmtGRmc0amV2TFNYYTY5RlNUMWlUTWxvcU9tcTMxQWhM?=
 =?utf-8?B?MWFOVU41R2kxWVh2YkhVcWdLa2N6a2RLUXI2TVBjK3pkcHYyaStjZlRhM1Vk?=
 =?utf-8?B?K1M4di8wNnBXR3lrOE13SUErR3pxNnliWVRpd2Y5ODJaV1FLT3ZuL3JLb0k4?=
 =?utf-8?B?L2lWTnNaL1g4VGxRWFNhSGJ2MGxEd21LZ0RsYnRscUFwSms0WStja3JXMjlo?=
 =?utf-8?Q?JvejKuem3ZEi5T7KR78YH0a27y4xKJ8KkQP3cft?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a64b23e-a7e4-4f3e-180a-08d948a7078a
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5129.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2021 22:14:07.4955
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3JmDmDY2VvhfFXLu38rSRxx4huRKkoVG9gTRr3Il06n3cPiT2cx2AFuCTmJ8c/HILEl08UdU9y8u9bHsu+tTUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5292
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

Am 2021-07-16 um 11:07 a.m. schrieb Theodore Y. Ts'o:
> On Wed, Jun 23, 2021 at 05:49:55PM -0400, Felix Kuehling wrote:
>> I can think of two ways to test the changes for MEMORY_DEVICE_GENERIC in
>> this patch series in a way that is reproducible without special hardware and
>> firmware:
>>
>> For the reference counting changes we could use the dax driver with hmem and
>> use efi_fake_mem on the kernel command line to create some DEVICE_GENERIC
>> pages. I'm open to suggestions for good user mode tests to exercise dax
>> functionality on this type of memory.
> Sorry for the thread necromancy, but now that the merge window is
> past....

No worries. Alejandro should have a new version of this series in a few
days, with updates to hmm_test and some fixes.


>
> Today I test ext4's dax support, without having any $$$ DAX hardware,
> by using the kernel command line "memmap=4G!9G:memmap=9G!14G" which
> reserves memory so that creates two pmem device and then I run
> xfstests with DAX enabled using qemu or using a Google Compute Engine
> VM, using TEST_DEV=/dev/pmem0 and SCRATCH_DEV=/dev/pmem1.
>
> If you can give me a recipe for what kernel configs I should enable,
> and what magic kernel command line arguments to use, then I'd be able
> to test your patch set with ext4.
That would be great!

Regarding kernel config options, it should be the same as what you're
using for DAX testing today. We're not changing or adding any Kconfig
options. But let me take a stab:

ZONE_DEVICE
HMM_MIRROR
MMU_NOTIFIER
DEVICE_PRIVATE (maybe not needed for your test)
FS_DAX

I'm not sure what you're looking for in terms of kernel command line,
other than the memmap options you already found. There are some more
options to run hmm_test with fake SPM (DEVICE_GENERIC) memory, but we're
already running that ourselves. That will also be in the next revision
of this patch series.

If you can run your xfstests with DAX on top of this patch series, that
would be very helpful. That's to make sure the ZONE_DEVICE page refcount
changes don't break DAX.

Regards,
  Felix


>
> Cheers,
>
> 						- Ted