Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3524851pxv;
        Mon, 19 Jul 2021 02:17:57 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyB3MidAy9C5CQ6uwUwqN703WDkYivI5QqRTpSeXTyCNnpihI66AWYzbeAg9Njp75HXpAc3
X-Received: by 2002:a05:6602:249a:: with SMTP id g26mr18064226ioe.150.1626686277566;
        Mon, 19 Jul 2021 02:17:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1626686277; cv=none;
        d=google.com; s=arc-20160816;
        b=jzUjr47KXvKTsO+aun8CwydzzqtVJEG9L2TYvLbO5+sDQr+TEew4nbnCtcds+jBOEY
         eZnEluQDjRgw1rOaq0TTPJD2M1l1Xkyx0xcVW42cuN/1VL7lLWNvSZPtUvK2MA5VjHpX
         o7Nz0s/aNHcuwLMrco2vrwAwuiu423Dg41/ORlBaf98nb2wRq4Tdm3yuLeC16itf5MXN
         R286z+cMwcic4VDz7oPffbLs3u81tJX6vMMsCX9POiwgJz/pK7rNAyTAUI0WgP5iS0XX
         GhehWPR4311ZwcSpcnpnEG2RFJWq4HTxAN9oIeSHdrHF1ec/NsU3Cj1e0ah4HiH0HT9o
         yTtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date;
        bh=cRtq3RTzSgEjmHnodO+6rzTPZhi7WA9DdvfUiaySiUs=;
        b=mHq5802mvk3LxSYfOluYQzlyR6bJlpftF4hTDqSmttW9nBYUZNdt/WX2lFILbs44ja
         obIJ75CkCNpLfY3fWH64g/EJGXwTFY/HLqiLCZhb4poy+aIGJV9LqYaT8jaIf5vfeZtf
         VaaX97GKUCVcopPIvkwRshobqNfSDQmSK2Vf+mdPcQmvg/kTciTOfHdO9plQGYQ7hzTt
         EQMVCZQa9FIwpRRzbrIfT+E8DmnWHxIFPzGVsIlR+joX7fUb7kyCUO2ptoPT0QhXqATh
         LVu7VAKrKxtDYQzv/GotvKm+A1dItTVaflKGlrz7NIxlP6AtKmfNMhM1pDxn2pw2oQB5
         1Jgg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org
Return-Path: <linux-ext4-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id b12si18809482ioj.88.2021.07.19.02.17.46;
        Mon, 19 Jul 2021 02:17:57 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234730AbhGSIhB (ORCPT <rfc822;k.plus.k.93@gmail.com>
        + 99 others); Mon, 19 Jul 2021 04:37:01 -0400
Received: from verein.lst.de ([213.95.11.211]:48645 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S235031AbhGSIhB (ORCPT <rfc822;linux-ext4@vger.kernel.org>);
        Mon, 19 Jul 2021 04:37:01 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 330C468B05; Mon, 19 Jul 2021 11:17:39 +0200 (CEST)
Date:   Mon, 19 Jul 2021 11:17:38 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Alex Sierra <alex.sierra@amd.com>
Cc:     akpm@linux-foundation.org, Felix.Kuehling@amd.com,
        linux-mm@kvack.org, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        hch@lst.de, jgg@nvidia.com, jglisse@redhat.com
Subject: Re: [PATCH v4 05/13] drm/amdkfd: generic type as sys mem on
 migration to ram
Message-ID: <20210719091738.GB30855@lst.de>
References: <20210717192135.9030-1-alex.sierra@amd.com> <20210717192135.9030-6-alex.sierra@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210717192135.9030-6-alex.sierra@amd.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Sat, Jul 17, 2021 at 02:21:27PM -0500, Alex Sierra wrote:
> +	migrate.flags = adev->gmc.xgmi.connected_to_cpu ?
> +			MIGRATE_VMA_SELECT_SYSTEM : MIGRATE_VMA_SELECT_DEVICE_PRIVATE;

Please just use a good old if/else to keep the code readable.