Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp892422pxv; Thu, 22 Jul 2021 15:17:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqzaqapj37woI3pfDa9iTDJHc+GjD6T92ZCQxQ5a8ENflODMRazIfgaLwtITMaTb+VKTcK X-Received: by 2002:a5e:db02:: with SMTP id q2mr1465607iop.172.1626992276112; Thu, 22 Jul 2021 15:17:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626992276; cv=none; d=google.com; s=arc-20160816; b=yv84S7BsZwVi7nnNgIWe35uDGgWtpsge29C2Mhx8uBhV371fyIpASm0a81tYrM14kl t3JBJfCs9UHAt+f1vg4f0jRQ66Zx3Z3vcTazFp+Wq05lrMk2DuXXtdP9AZEtb1b/nLwK 37mpM36YHMQ8rNDkqTWv0f/S+06uszhWyrbpl5rXtolclIsqj0oweMuyVNL/L86eeX8f 3VQxEzyoA15HnCSlVWSao+CQQf+utBUHhXSHAKSY1szcdgAqRu0X2e7TDSIeyFT5UHFL qd9LWScv4KUpaV9aFn+zoLMQA+AS8japQSTduHSuSos+L4tIMGvkNXvcEAzK+/o0J9ET bAqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=dMMGjoJ6l6MGxG72WEiHpe2cpxB+l0q+ZH2u6OJ1zPY=; b=TldslWXZCEZNcxqIoDVFCAuQyvaqMewtyWUSKszMfmmaov1NaSyAcsKJhMNhiSGh6P g09mYiDi1HX5gL0cR7zapdvxmzznb/6NUAPJ7AVf1rCadnxqcT27X+b5VXccAIv/3cf7 xTgyL5MNLEiV1tMyLOsvLrk6WuQzCO8AzdKTD1Gb+gy62N78rX40Z+6+bZAxHnUXcbQi z+HVf957cknnOverYVKnHEvrJa+zVha/9SoKK13R+mmyS/EvJEa9QZpG21rQWiplE+Kb ahHu5wT7SqDxP5BN28aKDhTaLn7pDBELJbijfGv2peHFx8ilki/n+3Ygiv1fU7KNTX4Y AIhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h5si35831486iol.44.2021.07.22.15.17.39; Thu, 22 Jul 2021 15:17:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231533AbhGVVgw (ORCPT + 99 others); Thu, 22 Jul 2021 17:36:52 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:39787 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232024AbhGVVgv (ORCPT ); Thu, 22 Jul 2021 17:36:51 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 16MMHGMV021590 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jul 2021 18:17:16 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 3A54115C37C0; Thu, 22 Jul 2021 18:17:16 -0400 (EDT) Date: Thu, 22 Jul 2021 18:17:16 -0400 From: "Theodore Ts'o" To: Lee Jones Cc: linux-kernel@vger.kernel.org, Andreas Dilger , Remy Card , "David S. Miller" , linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/1] fs: ext4: namei: trivial: Fix a couple of small whitespace issues Message-ID: References: <20210520125558.3476318-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jul 22, 2021 at 12:35:43PM +0100, Lee Jones wrote: > On Thu, 20 May 2021, Lee Jones wrote: > > > Cc: "Theodore Ts'o" > > Cc: Andreas Dilger > > Cc: Remy Card > > Cc: "David S. Miller" > > Cc: linux-ext4@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > fs/ext4/namei.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Any news on this please? > > Would you like me to submit a [RESEND]? Please don't send "checkpatch.pl --file" patches for the ext4 file system; if you must, please focus on files in the drivers directory, where they are more welcome. If developers are making changes to a file, fixing some checkpatch.pl whines is fine, but white-sapace only changes just obfuscates "git blame" code archology, and so the costs far outwieghs the costs. "Fix" is also not the right verb to use. For more information please see [1]. [1] https://gist.github.com/17twenty/8154928 If you are looking for subtantive ways of contributing to the ext4 file system, feel free to look at various syzbot warnings[2] and try to figure out what is going on there. [2] https://syzkaller.appspot.com/upstream (In some cases, the syzbot complaint has already been fixed, and it's just a matter of letting syzbot knoww that it has since been fixed by a particular commit. See [3] for more details.) [3] https://github.com/google/syzkaller/blob/master/docs/syzbot.md Cheers, - Ted