Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1274940pxv; Fri, 23 Jul 2021 04:32:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwen97z/71XyQdCkhfl+3ae5yq2jNrc+nZkbKaon5rE3zeZnXYdiyaL9u3l4c/BOsN+iAeQ X-Received: by 2002:a05:6e02:1e02:: with SMTP id g2mr3300665ila.6.1627039944561; Fri, 23 Jul 2021 04:32:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627039944; cv=none; d=google.com; s=arc-20160816; b=vSTL0wn937wx/WLGrZJ5Vj1NTDfhX1r0s8/INKJIyq+0mI5h6nc3eXwB3Oi6sMpMpk GOP2jO77KrOId7CQKZr9Vy4LLgc7/2HMcfwhwX6UIqdb7gav6SdBeohUl91mZm5M/zlh CCpsIIg0RMSaPfsIevhkuZ0jVuAFKdkaHyzYfAk7yTtv/ixe9eV33vdl2IM9OmCUrJPf 0e8JN5sFJkVIVqw5bUoQToKZeLNsvhHHsqJHDc7KminhDhqDztFltzzLPK6wU4KNHF3V UkS98xhXpWoMox7uWD1i0JAXKaLn4BcIBJzTnGWBpIxvkQeUk7Vgh7aamzZPPd7HTpfq vm+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=YLg4Et9TTMLd5DvbafzijTpfLafxEdhD4o1KLA4HYjw=; b=WHiud4qLBEi/Y6xWmoYcSjkqcqISi6128i90yux0gAYf0VrdSYNJVSRYy/2Teob7G/ hmLJYvD4v57CsA0lNW6fUhnGrJUPwQNxEtKXOQSoeY5+2ZwBAsO6056Q4XGfXskUUFWQ GPipAnXsqeIGqlEBRgToVPcO9zPdi1bDsuQo5+P7fCbXH/bP0ySFIDZTUyZCew20Iebl YKL6uhQXAMuY4nA9HiB4lpPHhc19Z0V2Dgy2J5ku77uuTI1GLVfQF2h77OgE32lP3Mhp kCYRvsuL4d8dn5kHpZbXRLgubm/43hEwbaCQlUaJwcl24dQ8Djkd2g+gdlWO14Y4CgMf /33w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t17si35111539jal.112.2021.07.23.04.32.05; Fri, 23 Jul 2021 04:32:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232681AbhGWKv3 (ORCPT + 99 others); Fri, 23 Jul 2021 06:51:29 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:56209 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231703AbhGWKv3 (ORCPT ); Fri, 23 Jul 2021 06:51:29 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 16NBVp0B016690 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jul 2021 07:31:51 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 0BBFE15C37C0; Fri, 23 Jul 2021 07:31:51 -0400 (EDT) Date: Fri, 23 Jul 2021 07:31:51 -0400 From: "Theodore Ts'o" To: Ye Bin Cc: jack@suse.cz, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com Subject: Re: [PATCH -next] ext4: Fix access uninitialized 'retval' in kmmpd Message-ID: References: <20210713022728.2533770-1-yebin10@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210713022728.2533770-1-yebin10@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jul 13, 2021 at 10:27:28AM +0800, Ye Bin wrote: > If (!ext4_has_feature_mmp(sb)) then goto 'wait_to_exit' label, but > retval not be uninitialized. > > Fixes: 61bb4a1c417e ("ext4: fix possible UAF when remounting r/o a mmp-protected file system") > Signed-off-by: Ye Bin Thanks, applied with a slightly fixed up commit description. - Ted