Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1965707pxv; Sat, 24 Jul 2021 00:44:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyBnHh8i1pu0g0SPDg9sQowJGj2JRkDDs33u8AW1LAOAJnu5jIN6JjstpPxtTHHuh1h+Yf X-Received: by 2002:a02:908a:: with SMTP id x10mr7376563jaf.30.1627112656190; Sat, 24 Jul 2021 00:44:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627112656; cv=none; d=google.com; s=arc-20160816; b=SMjPruio2HGEFnIud0NRHBKfDn7VHG5zpgCI+JSnTHyr29m7cI5ig4MXFElnynw+6B 7xM4YK8cXgvDvnvWgwyNZzOXuR9x4ZE9oNTTh5wfhtbrrkk7KS5a6DfoDExUsbtu1Wkz 9QKuvcSbVKa8/eUm/59q3LVFtReIbSn8URE5Tn9hHyIlwYLzKH/Tmz0IU5Cyl4Q4h9sM hzBsN1Tj/12aL/lPaLulzeld7ZF2/TrJoxKlnQr/hlG/o+9h0D1QvhFA3OqIapoZHn4n j1PAIGX5MomIt7x4MYutIvzSc+vz0Apw8DbfpSpjB0jBrbusckOsNkZFIy8Athc1GnNU D2jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=p4qbVHg1IF59H0YMV4jccads7zcNK8YJJGH4Vp8FcEE=; b=JSkv1JoWtHZoNujnQ2tJOk0BDGoXC40gVenbJx1EWnX+W9A3pw7uedNrBRVWKYLc0w 1PJzXVDGlfsA6rKChPeoBS4HI/uJmQclRNo5LHUbusFNQawHeu2OTNDJZjPoplL7IMAY u8SlSAxHYSqm4BaNaXNp2suxpHaW6wTe3NpLDuuWVU47XHs8fqxA2XnPKRcHjDx42P4c ugOS2CNmuX93fBLE4LAAp5eazNrAjdKB1j/7tSIndtbfrfeML/lSVeOcQLDA4K27asRc zv4o6DfYLajCTn+2wYz1C8r58VziYG0bpdE5EdzW4MU/z21BAjuNtKIi3BBTysMJ+Ny4 y2AA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OJ5avNAb; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t10si24567800jal.117.2021.07.24.00.44.04; Sat, 24 Jul 2021 00:44:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OJ5avNAb; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234415AbhGXHCa (ORCPT + 99 others); Sat, 24 Jul 2021 03:02:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234524AbhGXHC3 (ORCPT ); Sat, 24 Jul 2021 03:02:29 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5223AC061757; Sat, 24 Jul 2021 00:43:01 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id m1so5453431pjv.2; Sat, 24 Jul 2021 00:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=p4qbVHg1IF59H0YMV4jccads7zcNK8YJJGH4Vp8FcEE=; b=OJ5avNAbk2XFqgPswCPvf1OgYMMzXqRfe11KQJpYYvCcAK3bCE/gXxoEk6GiGXwnQ2 zzK8SfYba2XbepRMcb4SjyTjdH0sacsNaufhAfyCm+/mmbEU3vO+lWFOPbDfnN6jZGbk InGcsOa52ipwFFNZ5C9CJ84CIMm7SWNJkRs8TEBzi3cq51YQ+hG+6mDKwT9HYbIosrkK 53ZWcosohVGr9Aa863KYekATNJ/qZMMvwd9FvHl5tGO0qizlmVJicoZqYSW4sYoNhkUm 50gmUEvJIJVwi4irosZnPjcNg7Ym45XZa/D+ZbKEdEonKH9aWdmmiGRVJk3OZSUz4whL ZJsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=p4qbVHg1IF59H0YMV4jccads7zcNK8YJJGH4Vp8FcEE=; b=MvnGy2VHzpvafuzvgEnoqcKa7qnB6HocV4ircCVdIKuIBjRGocmdqaZA6pEW2x51GF 8Q2bPkXegcR6FX9wUjLnETgRMJFAwfn1P3CQxrb+MmEh53birBC0X8qZVUR1Hx8o3lhY 81zT1fftK86QHRNuooHFPRAlWAe0RgdORtgZSKNuzCKx8T1Is+Gud42GCLKxEbMfQNUz ij9eWjAts067FVhklNQnmx/fFU7EMR9d+mwE/9UW/DNs4euxzs2QjVkh4YqMLCjwIQv6 y7a6nv7dpDLek+qgPpfbjdnmHDKFi8HI2f1rtekQVrDksVde6AyMmfoEIpl2bAOwq+EL xnAg== X-Gm-Message-State: AOAM533NGcqm/Jmi+UTfdSYVJQ7HHnRX6YsIma95dL64/Ri7ho/wqMYh ufghR9yPGE8cQ1eqBakHTKS4RCMj8iQZkQ== X-Received: by 2002:a62:5b46:0:b029:38a:ce83:85c9 with SMTP id p67-20020a625b460000b029038ace8385c9mr835268pfb.11.1627112580872; Sat, 24 Jul 2021 00:43:00 -0700 (PDT) Received: from localhost.localdomain ([154.86.159.244]) by smtp.gmail.com with ESMTPSA id v31sm33002342pgl.49.2021.07.24.00.42.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 00:43:00 -0700 (PDT) From: Wang Jianchao To: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: tytso@mit.edu, adilger.kernel@dilger.ca Subject: [PATCH V3 3/5] ext4: remove the repeated comment of ext4_trim_all_free Date: Sat, 24 Jul 2021 15:41:22 +0800 Message-Id: <20210724074124.25731-4-jianchao.wan9@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210724074124.25731-1-jianchao.wan9@gmail.com> References: <20210724074124.25731-1-jianchao.wan9@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Wang Jianchao Reviewed-by: Andreas Dilger Signed-off-by: Wang Jianchao --- fs/ext4/mballoc.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index e3844152a643..34be2f07449d 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -6274,15 +6274,10 @@ static int ext4_try_to_trim_range(struct super_block *sb, * @max: last group block to examine * @minblocks: minimum extent block count * - * ext4_trim_all_free walks through group's buddy bitmap searching for free - * extents. When the free block is found, ext4_trim_extent is called to TRIM - * the extent. - * - * * ext4_trim_all_free walks through group's block bitmap searching for free * extents. When the free extent is found, mark it as used in group buddy * bitmap. Then issue a TRIM command on this extent and free the extent in - * the group buddy bitmap. This is done until whole group is scanned. + * the group buddy bitmap. */ static ext4_grpblk_t ext4_trim_all_free(struct super_block *sb, ext4_group_t group, -- 2.17.1