Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp2083743pxy; Mon, 2 Aug 2021 19:02:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTpSIjdI4agEjTc+cvttwOFB+tgpa93r+ltsTP3t5gYjIgygw1yzCwpyy4mzklsgKFpO6D X-Received: by 2002:a5d:8456:: with SMTP id w22mr487531ior.63.1627956151920; Mon, 02 Aug 2021 19:02:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627956151; cv=none; d=google.com; s=arc-20160816; b=URVHnhhxjYcZz93OrAJW8D2ihDolSjLKn2mObzjflESmbpUU1jOvEv7lQW7+C5Hyv4 m4czDV7zwjvcrDlwBHYqkVxHSTIB2cEZFWyqZGoe949F/0yBBJsRos7g6Qhl8qs/SElr jtXTLMUNV9XnmRfeuvrVmEh0sVIp/3A37KoFoFJxj4flE/Gsh0OoLgjmMLm5LgJGR0fE ZIInelMfuKPenYEksqi3jIWPuFu8Dxk3qQDAYy2vwpoJ6YK5x7mB5R4G+Pdr5E5hmnVR qEdRvYUQipz3/1QMNFNcnK5ln62FUHQuQcbCMamj3m0m5AOQiCw2r+qcmvBwxiKoPVwQ Aaog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=5f7DmsE2DwPGA+wMlHF/5VVW0hWvVxzma8VcsFMKK5M=; b=PvaH5oRkLmPWFOWKG/Zl69Gt/vPyuVmURXV/lQcc3bwvfXEP1EjpKnt3PQNUgK0ZdU Zzb9z4S7r4+GIioOs0iypkofgM4Ta14/A8brgptZ5cN9OTrqrD+AA5slc1kK9jP8CJsM XGY2MVRjU86JGzoKm6Zx2zFuf1VSggkFnDlgZTwVB6lJHMQaLAtLN3ToDwqEwyFJnQZP /L9O4yJk1Ni7mEtbTt0DjmE1/ixKK+AZM7u+xuqHbCzTY6ELkHMOO3eV2N54+mWQ4t7o BQYp5IM92lMt7P0p5ap8Yw74+tzvsfH3OlOYza6qKYAG/+2cn0i+pZVJAQudU9e/GapC mkqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 5si13461539iof.82.2021.08.02.19.02.13; Mon, 02 Aug 2021 19:02:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233505AbhHCCAb (ORCPT + 99 others); Mon, 2 Aug 2021 22:00:31 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:43124 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233449AbhHCCAb (ORCPT ); Mon, 2 Aug 2021 22:00:31 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 17320B1t009314 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 2 Aug 2021 22:00:11 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id EA01C15C3DD2; Mon, 2 Aug 2021 22:00:10 -0400 (EDT) Date: Mon, 2 Aug 2021 22:00:10 -0400 From: "Theodore Ts'o" To: wuguanghao Cc: linux-ext4@vger.kernel.org, linfeilong@huawei.com, liuzhiqiang26@huawei.com Subject: Re: [PATCH v3 04/12] ss_add_info_dir: don't zap the info->info_dirs and check whether Message-ID: References: <20210728015648.284588-1-wuguanghao3@huawei.com> <20210728015648.284588-2-wuguanghao3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210728015648.284588-2-wuguanghao3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jul 28, 2021 at 09:56:45AM +0800, wuguanghao wrote: > From: Wu Guanghao > > In ss_add_info_dir(), don't zap the info->info_dirs. At the same time, it is necessary > to check whether dirs[n_dirs] is a null pointer, otherwise a segmentation > fault will occur. > > Signed-off-by: Wu Guanghao > Signed-off-by: Zhiqiang Liu > Reviewed-by: Wu Bo Thanks, applied. - Ted