Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp2083956pxy; Mon, 2 Aug 2021 19:02:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+x9QXW47tLXLS7rasw19g8R6qGjDY9luNCp0Vr2EpwXUZYRTZfHNH1BErt5w/DvzMLyry X-Received: by 2002:a6b:6f11:: with SMTP id k17mr462385ioc.114.1627956171727; Mon, 02 Aug 2021 19:02:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627956171; cv=none; d=google.com; s=arc-20160816; b=QounL1EUuW7Rtvpy2cDV3+hSim/ic0kYr6nazgDBQBHtfQk8XpwZ7odGeys1B3XZB1 A8CqrhPI2acvNzsrJuo/MM3+2Y/HMt3POcbA7hO74c1M3em1nT6hhGp+zd/OgvGynSIW SSTT75TOfJUYIIhGSvq4EQUoMrTCsgD7DX9itR41JOgbm8qEjrZ/jbmu1iWE+cNFsL6+ fs+IkD29qQ5jQajt3M1+HdEIOTKHrL1HjyflTASt2s8QgR9NsWiUSzXzNBfV0F11MS3T jfKpoa5uHI9dS0+m1FDWRNBdiIUcWikqsNVgfhKS/POg1Bl4Ds/QYVkMnA28ImDE6zVs hIig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=BHsCDiVsXfvyQpsC+qjz+0S7jlVO4X/IgM3B2+bAuhg=; b=khQ9PkW3/tc/AirPP3I7d0UMORB0mhKsLwhw3xCaOP1hUdZo/DIejVsJ6dCnug0nQL UjN+57VeIVQ+9BNJiw4/Cz6YhRRL4Cvi1KNmKKUTjfR1T8WacPLUEYSwDbIlNwilY9M1 rQfUatYtvVYH88YFhBdTYKcNhWAHC9fuoeJBfhLV1oS4FB95p5mMaqgZeuoqzWwTXBf/ y1y7ysKzjHGEpDi+Cvko9ErSM8bBE35eRYfVej3zlLRPiuhl0vtvQvEC0pC/zoXXuRXQ jPwVhd9bdm2rPtMY97GGwy700++FUyDs9CHotUux42ULTbjD6WA5p57j4zq1GGTq1yRj bUnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g1si14677200ile.121.2021.08.02.19.02.40; Mon, 02 Aug 2021 19:02:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233270AbhHCCCM (ORCPT + 99 others); Mon, 2 Aug 2021 22:02:12 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:43581 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233200AbhHCCCM (ORCPT ); Mon, 2 Aug 2021 22:02:12 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 17321s4l010310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 2 Aug 2021 22:01:55 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id C55E615C3DD2; Mon, 2 Aug 2021 22:01:54 -0400 (EDT) Date: Mon, 2 Aug 2021 22:01:54 -0400 From: "Theodore Ts'o" To: wuguanghao Cc: linux-ext4@vger.kernel.org, linfeilong@huawei.com, liuzhiqiang26@huawei.com Subject: Re: [PATCH v3 05/12] ss_create_invocation: fix memory leak and check whether NULL pointer Message-ID: References: <20210728015648.284588-1-wuguanghao3@huawei.com> <20210728015648.284588-3-wuguanghao3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210728015648.284588-3-wuguanghao3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jul 28, 2021 at 09:56:46AM +0800, wuguanghao wrote: > From: Wu Guanghao > > In ss_create_invocation(), it is necessary to check whether > returned by malloc is a null pointer. > > Signed-off-by: Wu Guanghao > Signed-off-by: Zhiqiang Liu Thanks, applied. - Ted