Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 4 Aug 2021 14:15:53 +0200
From:   Jan Kara <jack@suse.cz>
To:     Theodore Ts'o <tytso@mit.edu>
Cc:     Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/9] quota: Do not account space used by project quota
 file to quota
Message-ID: <20210804121553.GC4578@quack2.suse.cz>
References: <20210616105735.5424-1-jack@suse.cz>
 <20210616105735.5424-3-jack@suse.cz>
 <YQlrGbFgxf8BYruB@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YQlrGbFgxf8BYruB@mit.edu>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue 03-08-21 12:13:13, Theodore Ts'o wrote:
> On Wed, Jun 16, 2021 at 12:57:28PM +0200, Jan Kara wrote:
> > Project quota files have high inode numbers but are not accounted in
> > quota usage. Do not track them when computing quota usage.
> > 
> > Signed-off-by: Jan Kara <jack@suse.cz>
> 
> Thanks, applied to the maint branch (since this is a bug fix unrelated
> to the orhpan inode feature).
> 
> It looks like this was an issue that wasn't picked up by our
> regression tests.  Do you have an sample image that you used while you
> were developing this patch, that perhaps we should be adding to our
> regression test suite?

So I've uncovered this just by code inspection when adding orphan file
feature. Checking this problem is not as simple as using a fs image (the
problem manifests only if we add new quota type using tune2fs). I've
created a test for it. I'll post it separately.

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR