Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
From:   Boyang Xue <bxue@redhat.com>
Date:   Thu, 5 Aug 2021 10:35:16 +0800
Message-ID: <CAHLe9YbqejLQJO-6-a0ETtNUitQtsYr3Q2b7xW4VV=6fXO6APw@mail.gmail.com>
Subject: [kernel-5.11 regression] tune2fs fails after shutdown
To:     linux-ext4@vger.kernel.org
Content-Type: multipart/mixed; boundary="0000000000009c776a05c8c6c570"
Precedence: bulk

--0000000000009c776a05c8c6c570
Content-Type: text/plain; charset="UTF-8"

Hi,

kernel commit

4274f516d4bc ext4: recalucate superblock checksum after updating free
blocks/inodes

had been reverted by

81414b4dd48 ext4: remove redundant sb checksum recomputation

since kernel-5.11-rc1. As a result, the original reproducer fails again.

Reproducer:
```
mkdir mntpt
fallocate -l 256M mntpt.img
mkfs.ext4 -Fq -t ext4 mntpt.img 128M
LPDEV=$(losetup -f --show mntpt.img)
mount "$LPDEV" mntpt
cp /proc/version mntpt/
./godown mntpt # godown program attached.
umount mntpt
mount "$LPDEV" mntpt
tune2fs -l "$LPDEV"
```

tune2fs fails with
```
tune2fs 1.46.2 (28-Feb-2021)
tune2fs: Superblock checksum does not match superblock while trying to
open /dev/loop0
Couldn't find valid filesystem superblock.
```

Tested on e2fsprogs-1.46.2 + kernel-5.14.0-0.rc3.29. I think it's a
regression. If this is the case, can we fix it again please?

Thanks,
Boyang

--0000000000009c776a05c8c6c570
Content-Type: application/octet-stream; name="godown.c"
Content-Disposition: attachment; filename="godown.c"
Content-Transfer-Encoding: base64
Content-ID: <f_kryazjid0>
X-Attachment-Id: f_kryazjid0

LyoKICogQ29weSB0aGlzIHByb2dyYW0gZnJvbSB4ZnN0ZXN0cy9zcmMvZ29kb3duLmMKICogY2hh
bmdlIHNvbWUgY29kZSB0byBtYWtlIHN1cmUgdGhpcyBwcm9ncmFtIGNhbgogKiBiZSBjb21waWxl
ZCBpbmRpdmlkdWFsbHksIGRvbid0IG5lZWQgdG8gY29tcGlsZQogKiB3aXRoIGFsbCB4ZnN0ZXN0
cyBwcm9ncmFtLiAKICogKHN0aWxsIGRlcGVuZHMgb24geGZzcHJvZ3MtZGV2ZWwgb2YgY291cnNl
KQogKgogKiBnY2MgLW8gZ29kb3duIGdvZG93bi5jIC1XYWxsCiAqCiAqIE1vZGlmaWVkIGJ5OiBa
b3JybyBMYW5nIDx6bGFuZ0ByZWRoYXQuY29tPgogKgogKi8KCiNkZWZpbmUgX0dOVV9TT1VSQ0UK
I2luY2x1ZGUgPHN0ZGlvLmg+CiNpbmNsdWRlIDxzeXNsb2cuaD4KI2luY2x1ZGUgPHN0cmluZy5o
PgojaW5jbHVkZSA8ZXJybm8uaD4KI2luY2x1ZGUgPHVuaXN0ZC5oPgojaW5jbHVkZSA8Z2V0b3B0
Lmg+CiNpbmNsdWRlIDxzeXMvdHlwZXMuaD4KI2luY2x1ZGUgPHN5cy9zdGF0Lmg+CiNpbmNsdWRl
IDxzeXMvc3RhdHZmcy5oPgojaW5jbHVkZSA8ZmNudGwuaD4KI2luY2x1ZGUgPHhmcy94ZnMuaD4K
CnN0YXRpYyBjaGFyICp4cHJvZ25hbWU7CgoKc3RhdGljIHZvaWQKdXNhZ2Uodm9pZCkKewoJZnBy
aW50ZihzdGRlcnIsICJ1c2FnZTogJXMgWy1mXSBbLXZdIG1udC1kaXJcbiIsIHhwcm9nbmFtZSk7
Cn0KCmludAptYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCnsKCWludCBjOwoJaW50IGZsYWc7
CglpbnQgZmx1c2hsb2dfb3B0ID0gMDsKCWludCB2ZXJib3NlX29wdCA9IDA7CglzdHJ1Y3Qgc3Rh
dCBzdDsKCWNoYXIgKm1udF9kaXI7CglpbnQgZmQ7CgogICAgICAJeHByb2duYW1lID0gYXJndlsw
XTsKCgl3aGlsZSAoKGMgPSBnZXRvcHQoYXJnYywgYXJndiwgImZ2IikpICE9IC0xKSB7CgkJc3dp
dGNoIChjKSB7CgkJY2FzZSAnZic6CgkJCWZsdXNobG9nX29wdCA9IDE7CgkJCWJyZWFrOwoJCWNh
c2UgJ3YnOgoJCQl2ZXJib3NlX29wdCA9IDE7CgkJCWJyZWFrOwoJCWNhc2UgJz8nOgoJCQl1c2Fn
ZSgpOwoJCQlyZXR1cm4gMTsKCQl9Cgl9CgoJLyogcHJvY2VzcyByZXF1aXJlZCBjbWQgYXJndW1l
bnQgKi8KCWlmIChvcHRpbmQgPT0gYXJnYy0xKSB7CgkJbW50X2RpciA9IGFyZ3Zbb3B0aW5kXTsK
CX0KCWVsc2UgewoJCXVzYWdlKCk7CgkJcmV0dXJuIDE7Cgl9CgoJaWYgKChzdGF0KG1udF9kaXIs
ICZzdCkpID09IC0xKSB7CgkJZnByaW50ZihzdGRlcnIsICIlczogZXJyb3Igb24gc3RhdCBcIiVz
XCI6ICVzXG4iLAoJCQl4cHJvZ25hbWUsIG1udF9kaXIsIHN0cmVycm9yKGVycm5vKSk7CgkJcmV0
dXJuIDE7Cgl9CgoJaWYgKCFTX0lTRElSKHN0LnN0X21vZGUpKSB7CgkJZnByaW50ZihzdGRlcnIs
ICIlczogYXJndW1lbnQgXCIlc1wiIGlzIG5vdCBhIGRpcmVjdG9yeVxuIiwKCQkJeHByb2duYW1l
LCBtbnRfZGlyKTsKCQlyZXR1cm4gMTsKCX0KCgkKI2lmIDAKCXsKCQlzdHJ1Y3Qgc3RhdHZmcyBz
dHZmczsKCQlpZiAoKHN0YXR2ZnMobW50X2RpciwgJnN0dmZzKSkgPT0gLTEpIHsKCQkJZnByaW50
ZihzdGRlcnIsICIlczogZXJyb3Igb24gc3RhdGZzIFwiJXNcIjogJXNcbiIsCgkJCQl4cHJvZ25h
bWUsIG1udF9kaXIsIHN0cmVycm9yKGVycm5vKSk7CgkJCXJldHVybiAxOwoJCX0KCgkJaWYgKHN0
cmNtcChzdHZmcy5mX2Jhc2V0eXBlLCAieGZzIikgIT0gMCkgewoJCQlmcHJpbnRmKHN0ZGVyciwg
IiVzOiBmaWxlc3lzIGZvciBcIiVzXCIgaXMgbm90IFhGUzpcIiVzXCJcbiIsCgkJCQl4cHJvZ25h
bWUsIG1udF9kaXIsIHN0dmZzLmZfYmFzZXR5cGUpOwoJCQlyZXR1cm4gMTsKCQl9Cgl9CiNlbmRp
ZgoKCglmbGFnID0gKGZsdXNobG9nX29wdCA/IFhGU19GU09QX0dPSU5HX0ZMQUdTX0xPR0ZMVVNI
IAoJCQkgICAgOiBYRlNfRlNPUF9HT0lOR19GTEFHU19OT0xPR0ZMVVNIKTsKCglpZiAodmVyYm9z
ZV9vcHQpIHsKCQlwcmludGYoIk9wZW5pbmcgXCIlc1wiXG4iLCBtbnRfZGlyKTsKCX0KCWlmICgo
ZmQgPSBvcGVuKG1udF9kaXIsIE9fUkRPTkxZKSkgPT0gLTEpIHsKCQlmcHJpbnRmKHN0ZGVyciwg
IiVzOiBlcnJvciBvbiBvcGVuIG9mIFwiJXNcIjogJXNcbiIsCgkJCXhwcm9nbmFtZSwgbW50X2Rp
ciwgc3RyZXJyb3IoZXJybm8pKTsKCQlyZXR1cm4gMTsKCX0KCglpZiAodmVyYm9zZV9vcHQpIHsK
CQlwcmludGYoIkNhbGxpbmcgWEZTX0lPQ19HT0lOR0RPV05cbiIpOwoJfQoJc3lzbG9nKExPR19X
QVJOSU5HLCAieGZzdGVzdHMtaW5kdWNlZCBmb3JjZWQgc2h1dGRvd24gb2YgJXM6XG4iLAoJCW1u
dF9kaXIpOwoJaWYgKCh4ZnNjdGwobW50X2RpciwgZmQsIFhGU19JT0NfR09JTkdET1dOLCAmZmxh
ZykpID09IC0xKSB7CgkJZnByaW50ZihzdGRlcnIsICIlczogZXJyb3Igb24geGZzY3RsKEdPSU5H
RE9XTikgb2YgXCIlc1wiOiAlc1xuIiwKCQkJeHByb2duYW1lLCBtbnRfZGlyLCBzdHJlcnJvcihl
cnJubykpOwoJCXJldHVybiAxOwoJfQoKCWNsb3NlKGZkKTsKCglyZXR1cm4gMDsKfQo=
--0000000000009c776a05c8c6c570--