Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp322789pxt; Fri, 6 Aug 2021 02:59:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgGEAzbgAA4K2jDdl9awKe9znLjLRyKu5hu7pQo/i/5tp8gVGJ/UJVGLXkHIKoGy/nuJyY X-Received: by 2002:a17:906:c251:: with SMTP id bl17mr9070202ejb.219.1628243946352; Fri, 06 Aug 2021 02:59:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628243946; cv=none; d=google.com; s=arc-20160816; b=KG+7G1MnygUrrVHH1iIMaUeQ2JfmcI7v7o8v5NBtAttTem1XO6IjtWbc0Cb/Dd2EMc 0/M1ICuNpE3izNu+zWG7O5u4mo8ReAdEZA1nupV+xSwGhfTHoMUkJ2vpuvedef5xUslT 0spFTX35USzkFQmzhrOwfQBJEv2l/1nv51SDmD2RXK21P1hOfnt5i9N/qFiiNMz8xSTF Q8WTBU3FMrAAuxTJfyIROplGhNeUgwpYnIBTBR7+Wuh5LWyNRNvyom5cNKrDlLtr94ms 2D4iB2l45Oe3CfB5DFVynJy6znA2yINqaDPR8YZIDS1zjnfbXpnDs2M0xJuBPbgmp94g GuFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=sb8h5uoCELs6vcLcpaMhZUmgx+JvOd9nGgs0hNSi1UI=; b=KODv0sfEylTw3JTQ1ggXvmIw8yHIXfWE0WY8sKB2V94m1+LAjw/UXYmG7fCMQgaXn2 ec/UXRxALq5jNWk/8ttLrbsbz2RvPmtzvau/njnqIFNnzmaj2/Zf7sgYn6Dp0OIjWU6h Kpe5Cye2DWIzgunZ9ZlDxs1dLkQPn798EnJ5e7fiZLcGyA54R3wwDExbqQEAZsR4eN91 WGzunhcZVM3u5GK2UaV06RPzR1ejHIz7uhjjIYoyHGdPFvElL9M4SU1TnpTH52zabtmb emw6X1ufxvvrfU3HcrkLw3QVylGJpRJz//VFYBkoj5J9EFAhfcFxZREkn220l1Qahkjh w7QQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X7bYd0+e; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w20si8409025eds.417.2021.08.06.02.58.35; Fri, 06 Aug 2021 02:59:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X7bYd0+e; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231672AbhHFJ6p (ORCPT + 99 others); Fri, 6 Aug 2021 05:58:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54102 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229725AbhHFJ6o (ORCPT ); Fri, 6 Aug 2021 05:58:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628243908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=sb8h5uoCELs6vcLcpaMhZUmgx+JvOd9nGgs0hNSi1UI=; b=X7bYd0+eCLMuITi3uNVHtyQ2l7r5t3riu3TFEhlIh1K4IcTIJsF7GgHwjxKDiSsMLOeESy mm0fiDZ0uOZ4OWy6AaKEkAiAG/KTEehqFhaxnz1/8xcq/PZsf15Gtq3IphDAIEcNrP4XAs D8XBJ+GCTIrMBX2/8aLCsQNJIk4hWWw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-556-eoIqYEoMP-GxyHVzKTlDkg-1; Fri, 06 Aug 2021 05:58:27 -0400 X-MC-Unique: eoIqYEoMP-GxyHVzKTlDkg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 96C4B87D541; Fri, 6 Aug 2021 09:58:26 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.193.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id DDB356A057; Fri, 6 Aug 2021 09:58:25 +0000 (UTC) From: Lukas Czerner To: tytso@mit.edu Cc: linux-ext4@vger.kernel.org Subject: [PATCH 1/7] e2fsck: value stored to err is never read Date: Fri, 6 Aug 2021 11:58:14 +0200 Message-Id: <20210806095820.83731-1-lczerner@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Remove it to silence clang warning. Signed-off-by: Lukas Czerner --- e2fsck/recovery.c | 1 - 1 file changed, 1 deletion(-) diff --git a/e2fsck/recovery.c b/e2fsck/recovery.c index 25744f08..48b5efd2 100644 --- a/e2fsck/recovery.c +++ b/e2fsck/recovery.c @@ -760,7 +760,6 @@ static int do_one_pass(journal_t *journal, */ jbd_debug(1, "JBD2: Invalid checksum ignored in transaction %u, likely stale data\n", next_commit_ID); - err = 0; brelse(bh); goto done; } -- 2.31.1