Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp4646520pxt; Wed, 11 Aug 2021 10:37:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTFEiNqdcWa+TlgS5alX08ixrj2sZyRfw9C8h88Cg2YxPNW0ArGK3bF/ByxaKQ4wxc33sZ X-Received: by 2002:a17:906:3157:: with SMTP id e23mr4855135eje.29.1628703420726; Wed, 11 Aug 2021 10:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628703420; cv=none; d=google.com; s=arc-20160816; b=udhtHyZbZO65gs5l9I2ULOhbudETKpQ7QYPJvUnSnFOfZW8l4rHLfhkd6y/hdk88Or Z4eHBlgN/l/TY0padxTKHtG90u7p0AFXmEnt19wniFALp0xa7Dz0DltqRzE2n1uiRkxk OvtKW9LhGvlZg1MyRyfq8uhcB6Tn2GdVqwLe8rrf6KOQj0GJ0hcZCmgLtzUksNMm/YPw hSQgdtVpw874+/GwfIKMLncXG8dKoQYa91TWyFOhUU3NuVnxZR2L47VF7XScMoc/VvOu mj9SLg4qeX+awA/iTthc20kN42a44VEfGsCs5TyiwGxBHVuZoH55kPYBlSa7VIAb8Het pTow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sn996wyP1762RVthxVYilsh2trpZDoQDtSXbn8LQEl0=; b=QNPCt2hj+ON9r2DJrlLYSs8SBXGnm9sd5lmmTai9hqwL3/ClUAB1jUBUNBSXuxNisK p9hT0HGAh+L5x3g2JaX5PCT18p8uNjgbOdHYzdflGavi37C1xh/AAQz8kb8JC+9TFvy4 2sfkPyBWod7RaOJ50GxHLpNP3RY3JZJWpbU6HvhpLXIiUiHvfK+bAWaMlbmL3mY3UHr8 Dh2etUMqgcIVlxxgztLRPiWBD1fc0O6y+Y86d/BrH62gE0v492yqWfLwWKBVbEwA0+Gl Hmwwc5U61qtaPNrYczAGmApmAMMHQ6PoDScBRr+GqzSr268VOEDEN+WEVgATdJaQGtHR d8WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HXUPMi8S; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y13si2955822eda.441.2021.08.11.10.34.54; Wed, 11 Aug 2021 10:37:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HXUPMi8S; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229535AbhHKReI (ORCPT + 99 others); Wed, 11 Aug 2021 13:34:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52660 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbhHKReI (ORCPT ); Wed, 11 Aug 2021 13:34:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628703224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sn996wyP1762RVthxVYilsh2trpZDoQDtSXbn8LQEl0=; b=HXUPMi8Sqm3mbvbkeA/BOdhv1uilXxM6FviNXZRXlqXN8uJcUTw7ptwfyfecv5+KvJ/7Kp qb71/zGK5ZV5so/jDHLUXbVRrLtpiPatAL2ss+lLxyrUOg9fr5hQA2U+LDPXX+UDUaYtrx ievQpB9lpQ3erJxzfbsa/ONi5HgW5aM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242-EUH6_ZzyNqW1tLQO1_bJuQ-1; Wed, 11 Aug 2021 13:33:43 -0400 X-MC-Unique: EUH6_ZzyNqW1tLQO1_bJuQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 669BF824F8C; Wed, 11 Aug 2021 17:33:42 +0000 (UTC) Received: from work (unknown [10.40.192.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90E92781E7; Wed, 11 Aug 2021 17:33:41 +0000 (UTC) Date: Wed, 11 Aug 2021 19:33:38 +0200 From: Lukas Czerner To: Theodore Ts'o Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/7] e2fsck: value stored to err is never read Message-ID: <20210811173338.ikxkrprvdo345zef@work> References: <20210806095820.83731-1-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Aug 10, 2021 at 10:58:56AM -0400, Theodore Ts'o wrote: > On Fri, Aug 06, 2021 at 11:58:14AM +0200, Lukas Czerner wrote: > > Remove it to silence clang warning. > > > > Signed-off-by: Lukas Czerner > > Applied, thanks. > > Note that we try to keep e2fsck/recovery.c and fs/jbd2/recovery.c in > sync, so it's appreciated patches sent to e2fsck/recovery.c or > fs/jbd2/recovery.c is sent to the other. I can take care of it in > this case. > > Cheers, > > - Ted Allright, I'll keep that in mind for the next time. Thanks! -Lukas