Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <34413996-BBB2-4862-ABFE-BA3420C640F5@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_02CC29B2-F05C-47B3-B871-E2F6BE632219";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] mke2fs: warn about missing y2038 support when formatting
 fresh ext4 fs
Date:   Wed, 11 Aug 2021 18:48:23 -0600
In-Reply-To: <20210811233253.GC3601392@magnolia>
Cc:     Theodore Ts'o <tytso@mit.edu>,
        linux-ext4 <linux-ext4@vger.kernel.org>
To:     "Darrick J. Wong" <djwong@kernel.org>
References: <20210811233253.GC3601392@magnolia>
Precedence: bulk


--Apple-Mail=_02CC29B2-F05C-47B3-B871-E2F6BE632219
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Aug 11, 2021, at 5:32 PM, Darrick J. Wong <djwong@kernel.org> wrote:
>=20
> From: Darrick J. Wong <djwong@kernel.org>
>=20
> Filesystems with 128-byte inodes do not support timestamps beyond the
> year 2038.  Since we're now less than 16.5 years away from that point,
> it's time to start warning users about this lack of support when they
> format an ext4 filesystem with small inodes.
>=20
> First, change the mke2fs.conf file to specify 256-byte inodes even for
> small filesystems, then add a warning to mke2fs itself if someone is
> trying to make us format an ext4 filesystem with 128-byte inodes.
>=20
> Note that we /don't/ warn about these things if the user has signalled
> that they want an old format such as ext2, ext3, or hurd.  Everyone
> should know by now that those are legacy.
>=20
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> misc/mke2fs.c       |   35 +++++++++++++++++++++++++++++++++++
> misc/mke2fs.conf.in |    4 ++--
> 2 files changed, 37 insertions(+), 2 deletions(-)
>=20
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 92003e11..b16880c2 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -1537,6 +1537,30 @@ static int get_device_geometry(const char =
*file,
> }
> #endif
>=20
> +/*
> + * Returns true if the user is forcing an old format (e.g. ext2, =
ext3).
> + *
> + * If there is no fs_types list, the user invoked us with no explicit =
type and
> + * gets the default (ext4) format.  If we find the latest format =
(ext4) in the
> + * type list, some combination of program name and -T argument put us =
in ext4
> + * mode.  Anything else (ext2, ext3, hurd) and we return false.
> + */
> +static inline int
> +old_format_forced(char **fs_types)
> +{
> +	int found_ext4 =3D 0;
> +	int i;
> +
> +	if (!fs_types)
> +		return 0;
> +
> +	for (i =3D 0; fs_types[i]; i++)
> +		if (!strcmp(fs_types[i], "ext4"))
> +			found_ext4 =3D 1;
> +
> +	return !found_ext4;
> +}
> +
> static void PRS(int argc, char *argv[])
> {
> 	int		b, c, flags;
> @@ -2603,6 +2627,17 @@ static void PRS(int argc, char *argv[])
> 		exit(1);
> 	}
>=20
> +	/* If the user didn't tell us to format with an old ondisk =
format... */
> +	if (!old_format_forced(fs_types)) {
> +		/*
> +		 * ...warn them that filesystems with 128-byte inodes =
will not
> +		 * work properly beyond 2038.
> +		 */
> +		if (inode_size =3D=3D EXT2_GOOD_OLD_INODE_SIZE)
> +			printf(
> +_("128-byte inodes cannot handle dates beyond 2038 and are =
deprecated\n"));
> +	}
> +
> 	/* Make sure number of inodes specified will fit in 32 bits */
> 	if (num_inodes =3D=3D 0) {
> 		unsigned long long n;
> diff --git a/misc/mke2fs.conf.in b/misc/mke2fs.conf.in
> index 01e35cf8..2fa1a824 100644
> --- a/misc/mke2fs.conf.in
> +++ b/misc/mke2fs.conf.in
> @@ -16,12 +16,12 @@
> 	}
> 	small =3D {
> 		blocksize =3D 1024
> -		inode_size =3D 128
> +		inode_size =3D 256
> 		inode_ratio =3D 4096
> 	}
> 	floppy =3D {
> 		blocksize =3D 1024
> -		inode_size =3D 128
> +		inode_size =3D 256
> 		inode_ratio =3D 8192
> 	}
> 	big =3D {


Cheers, Andreas


--Apple-Mail=_02CC29B2-F05C-47B3-B871-E2F6BE632219
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmEUb9gACgkQcqXauRfM
H+CGABAAuRTZL34ewCQJJ8W5WJX8d15rxyw9aei+bkoCFzbNc/bJqloJMv+OW/Xh
ygz608JAAPsv2O05EspoTo9m1BViZVkSNUIb+dlL8E4lApWvE2tEyQ6YnVa74Rm+
g3+kNb6f0bNzEQ+aeC35j7+07eW+cSb2eTnTEFKmKcL/bzBOPqKNu7hZoI5VIafY
G3vzH8pGz64wR9EAfYy+QmBqN0xLJ60z5P2p/fBQwWMssWVIJAD7TLa4tkaFyip7
HyanNzCMLBn22LtjaLgXV+XkFgZ1rwBNOPLN0RqIwlmOJPf827cqT7JBY8HMd5oB
zqUWhbSAPSrZ2pBTZJDkL7u5gmH0ir/SL0lkEYE7yc368trrIvqd2/GNUfQV9V1C
baIH+FQuCbJbyR3ZkUWV7ZvXfZkRld0zdcvsHgvr3x3xfmAXrdVcPTUDwOEWI3aA
e6jklDCeUNO5Mwhe1d9p7hXrJburEDuMbRkn0fzLmQy6I9ucOduEbrepJw0a3v7w
w+Ydt0s4oVAWWxxcmvuIW5LXyyGgkdAnV4nBraF9ucwlm0VS/6Wx3ajzzh9/sUCZ
Y8/vnsgi5551130yHXiCWYKhvLbXYYyLfDoGx8HZkroWuFeGQdbuCq3le81xo1ew
CeoyW6EwiNtUTPnuAVR7Fj6rk42nnN9MIIBbw4z7TbgbgNCRSvY=
=yA5N
-----END PGP SIGNATURE-----

--Apple-Mail=_02CC29B2-F05C-47B3-B871-E2F6BE632219--