Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Aug 2021 16:20:47 +0200
From:   Jan Kara <jack@suse.cz>
To:     Gabriel Krisman Bertazi <krisman@collabora.com>
Cc:     Jan Kara <jack@suse.cz>, jack@suse.com, amir73il@gmail.com,
        djwong@kernel.org, tytso@mit.edu, david@fromorbit.com,
        dhowells@redhat.com, khazhy@google.com,
        linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-api@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v5 14/23] fanotify: Encode invalid file handler when no
 inode is provided
Message-ID: <20210812142047.GG14675@quack2.suse.cz>
References: <20210804160612.3575505-1-krisman@collabora.com>
 <20210804160612.3575505-15-krisman@collabora.com>
 <20210805095618.GF14483@quack2.suse.cz>
 <87fsvf65zu.fsf@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87fsvf65zu.fsf@collabora.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed 11-08-21 17:12:05, Gabriel Krisman Bertazi wrote:
> Jan Kara <jack@suse.cz> writes:
> >> @@ -376,14 +371,24 @@ static int fanotify_encode_fh(struct fanotify_fh *fh, struct inode *inode,
> >>  		fh->flags |= FANOTIFY_FH_FLAG_EXT_BUF;
> >>  	}
> >>  
> >> -	dwords = fh_len >> 2;
> >> -	type = exportfs_encode_inode_fh(inode, buf, &dwords, NULL);
> >> -	err = -EINVAL;
> >> -	if (!type || type == FILEID_INVALID || fh_len != dwords << 2)
> >> -		goto out_err;
> >> -
> >> -	fh->type = type;
> >> -	fh->len = fh_len;
> >> +	if (inode) {
> >> +		dwords = fh_len >> 2;
> >> +		type = exportfs_encode_inode_fh(inode, buf, &dwords, NULL);
> >> +		err = -EINVAL;
> >> +		if (!type || type == FILEID_INVALID || fh_len != dwords << 2)
> >> +			goto out_err;
> >> +		fh->type = type;
> >> +		fh->len = fh_len;
> >> +	} else {
> >> +		/*
> >> +		 * Invalid FHs are used on FAN_FS_ERROR for errors not
> >> +		 * linked to any inode. Caller needs to guarantee the fh
> >> +		 * has at least FANOTIFY_NULL_FH_LEN bytes of space.
> >> +		 */
> >> +		fh->type = FILEID_INVALID;
> >> +		fh->len = FANOTIFY_NULL_FH_LEN;
> >> +		memset(buf, 0, FANOTIFY_NULL_FH_LEN);
> >> +	}
> >
> > Maybe it will become clearer later during the series but why do you set
> > fh->len to FANOTIFY_NULL_FH_LEN and not 0?
> 
> Jan,
> 
> That is how we encode a NULL file handle (i.e. superblock error).  Amir
> suggested it would be an invalid FILEID_INVALID, with a zeroed handle of
> size 8.  I will improve the comment on the next iteration.

Thanks for info. Then I have a question for Amir I guess :) Amir, what's
the advantage of zeroed handle of size 8 instead of just 0 length file
handle?

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR