Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp530686pxb;
        Wed, 18 Aug 2021 07:58:52 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwB8DF0j0RSqO3Q6XzU0RNDulsLFhVjHmadIBC2Oo+zRPHYGKrOMMnvUU9WSE91TceEWPhc
X-Received: by 2002:a6b:d20c:: with SMTP id q12mr7562900iob.121.1629298732353;
        Wed, 18 Aug 2021 07:58:52 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1629298732; cv=none;
        d=google.com; s=arc-20160816;
        b=mni46w0NuuHX3XzaL42fYZebRqHhErAgL9a2wW2BRldfNCJHSRMymxwbaT/4gVHrar
         8iC/l5QKXFda1Rll22LIAKOOvKehzxUZXlebUaP/lXb9ycATKl1fOuM28Vz3ru3FdF4s
         UuVYtj3AJkSJFFkm2HPiv2kDJsrd0B0FxXVmUSyqyerwL4Pb5AuJJzJAFGzwOBsRQvsF
         i7Sn+S/9O8XXAPx2U8VDvQiSUzoT3zOKFJwso4kNmXA8yYr8t28mY2hIrZ7Iq1h4zg4m
         Y7OzCGMmcEnGk77YuaMlr6O2PwinBZgegnsIy6Tc9alJMfdYljeC28XVYnU15n1BNZ40
         fZMQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=2g9pHgPWd8S7JZggCdeaLifcdNQhzjXv9Us4Fn7c/eI=;
        b=BTR2Yi9CPj6gWpiFJu/oirJ5SxlMxqyCQbCY9aMdTpYuUNDwR5qMZ7DNV5T82Fj4e+
         tkLy2PKZE751jPGbicq3zYJdzmKpMxw+S95jJSkk285t1URdUUgtP/YmzcjVnT31iFen
         TiWGNctKOJep5o0PnBb5h8/1GB8TRhKOJ9FaU1O4VWn2tk2KLFTmfh7xORnLcoj66Ye5
         p11NDZeqYGyHBDgBenBYF6lACm6JF2mvcvwyov3p3vjf+yqHWeWkGiVVfbxtZvVue5q1
         STpXurRLfKGDEPxRLfme0Khd6Wvc83BTVH0KvqyZ7agjzTRoNvhqbXkb+dlgc9e5oY3Z
         fjMQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=N8qRgySg;
       spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org
Return-Path: <linux-ext4-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id k39si6577915jav.114.2021.08.18.07.58.37;
        Wed, 18 Aug 2021 07:58:52 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=N8qRgySg;
       spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S238799AbhHRO6h (ORCPT <rfc822;sonicqiang@gmail.com> + 99 others);
        Wed, 18 Aug 2021 10:58:37 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57158 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S238872AbhHRO6e (ORCPT
        <rfc822;linux-ext4@vger.kernel.org>); Wed, 18 Aug 2021 10:58:34 -0400
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 119B0C061764;
        Wed, 18 Aug 2021 07:58:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=2g9pHgPWd8S7JZggCdeaLifcdNQhzjXv9Us4Fn7c/eI=; b=N8qRgySgPaN8uFwsK80Yh+8FUX
        VR3QrfrKBDWlRNxVfoy9ZZH7x4PzD/Rq9q7K3Vsq+YSfsxbfK8mYMQf8gQhKILSXrkva9jhbPHmwt
        1epA5C+rpKIVUWfFLqSiEv34+yfGAeHpn0xDEacnhYKKdNG5rRurcqZGU8EqLTW+zIxJ3a/5wg2mq
        dR6pbhupiIJ/Mx6b7er3EtvyWEyzZ7JJn74hIKTJAcOpWkz6LiKTGiysweRIs3APr6/wBZAMAfAMk
        CFPtXiU94BMz6MAOVwCPFqoPvSsbkPuDsURTCJzG/g1if/amVJWLIofqClORmA2pEiStrDVmNAWsX
        fNUatxHw==;
Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1mGMzz-003xBU-UN; Wed, 18 Aug 2021 14:57:08 +0000
Date:   Wed, 18 Aug 2021 15:56:59 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Gabriel Krisman Bertazi <krisman@collabora.com>,
        Shreeya Patel <shreeya.patel@collabora.com>,
        linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 11/11] unicode: only export internal symbols for the
 selftests
Message-ID: <YR0fuyqe7NS+mCf9@casper.infradead.org>
References: <20210818140651.17181-1-hch@lst.de>
 <20210818140651.17181-12-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210818140651.17181-12-hch@lst.de>
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Wed, Aug 18, 2021 at 04:06:51PM +0200, Christoph Hellwig wrote:
> The exported symbols in utf8-norm.c are not needed for normal
> file system consumers, so move them to conditional _GPL exports
> just for the selftest.

Would it be better to use EXPORT_SYMBOL_NS_GPL()?