Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1705367pxb; Mon, 23 Aug 2021 02:35:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxX7KITQ9v2qZKo8itMfSR8hpP7y1H9t3CcgSTmU4fnUW2PrGWYEiGT9CIMhwLEmNH6TkZ X-Received: by 2002:aa7:d40e:: with SMTP id z14mr36954429edq.250.1629711351430; Mon, 23 Aug 2021 02:35:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629711351; cv=none; d=google.com; s=arc-20160816; b=F+8DWsLzBZcLV6gOUjmsUs/TuQCZiGrsenmcehbYrseRBwchSZMxDKeaSXL7KbgASC be1Eg0Y2tZetldx3GY+aUa6kcElbyMZaWVoFSsgllFydt7vWYVod0aIsQSATxJLB+8qE J25qNH4fwq990z87IUMSJZt06zOgxiovi3a7N/6iGw6auPDwkjt3cBgtmDXJoRLpcIiM PpZMg7FnaXBGP1q70N3/dH3ydl6VNIdBrvfVu7QJxS2kdXqhP6lt2V+7+A5ZsC5JZ32p xO+AxQeKjoKG29vxZvY7pHuRi5f9BAmtIc4K0aMDQACQQN4FTtSE5uXWx9PFkaVkTNvz in/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=ZEQXU303m18GEih/91eVH67ti89qaTIhbqs+WseBOiM=; b=xo6xiFW/G40wtAjChjkbDpvBiLOMBADRjgz8DguZozembE2SA0Vf6LMGwERwZ2igqp ZUKcUnHV7Tv4z5Sw3cPDoYVtKitxeMj885ymvZ+WhdFYgl7qKLCJBR99O1FzAoELJjiq fNtK3w/9UpGEr8XUp7SjvaeJTCYI6Teep8b90t2aAdbw3wPu96hdTAYPkTSTv+Lpnqo6 kGcm/9O/swpoUDP+A+OF6dlBV1A7Nl6WekRXgrvgZRhEBIFE3lnPJfoT9NKASd0tBtlv Tr9FDpc+yJJE4ywa0rEGXNGn5jzYQbh4wQBAK/lEW6LcRHBL5VeReXWwE2RMFtcs0Ury QeSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=sYGV4y1j; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e20si13591274eds.158.2021.08.23.02.35.27; Mon, 23 Aug 2021 02:35:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=sYGV4y1j; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231861AbhHWJgH (ORCPT + 99 others); Mon, 23 Aug 2021 05:36:07 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:40132 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231679AbhHWJgH (ORCPT ); Mon, 23 Aug 2021 05:36:07 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 8A9BC21EDB; Mon, 23 Aug 2021 09:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1629711324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZEQXU303m18GEih/91eVH67ti89qaTIhbqs+WseBOiM=; b=sYGV4y1jYMnWB1NyGZqlD/SPcbdTAb0HtvMrPQYtFkZhVP5UbLFVKyxgsTd4Ti8akIaclP RnQ3Cz8FVwNcwyohnfNb8SibGA15VZZpeWmFdgdqOvELCX9NeXqFvK5wSpe5FLEoRfCl/s D12I3XC84UDjca8QBfzzsui8Yv3RwDs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1629711324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZEQXU303m18GEih/91eVH67ti89qaTIhbqs+WseBOiM=; b=XiuJDPz7pWuCWrv2iIhrq6MasytlLYcIGfiYluG+C/8YxoPph/j0GG5HkpP9XTnI/G2nrc Z2VOsmImzwRzpCAg== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id 60074A3BB0; Mon, 23 Aug 2021 09:35:24 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 0AC231E3B01; Mon, 23 Aug 2021 11:35:24 +0200 (CEST) Date: Mon, 23 Aug 2021 11:35:24 +0200 From: Jan Kara To: Matthew Bobrowski Cc: krisman@collabora.com, pvorel@suse.cz, Amir Goldstein , kernel@collabora.com, Khazhismel Kumykov , Jan Kara , Ext4 , LTP List Subject: Re: [LTP] [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR Message-ID: <20210823093524.GB21467@quack2.suse.cz> References: <20210802214645.2633028-1-krisman@collabora.com> <20210802214645.2633028-4-krisman@collabora.com> <87fsvphksu.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat 21-08-21 07:58:07, Matthew Bobrowski wrote: > On Fri, Aug 20, 2021 at 12:21:19PM +0200, Petr Vorel wrote: > > Hi all, > > > > > No problem. That's what review is for ;-) > > > > > BTW, unless anyone is specifically interested I don't think there > > > is a reason to re post the test patches before the submission request. > > > Certainly not for the small fixes that I requested. > > > > > I do request that you post a link to a branch with the fixed test > > > so that we can experiment with the kernel patches. > > > > > I've also CC'ed Matthew who may want to help with review of the test > > > and man page that you posted in the cover letter [1]. > > > > @Amir Thanks a lot for your review, agree with all you mentioned. > > > > @Gabriel Thanks for your contribution. I'd also consider squashing some of the > > commits. > > Is the FAN_FS_ERROR feature to be included within the 5.15 release? If so, > I may need to do some shuffling around as these LTP tests collide with the > ones I author for the FAN_REPORT_PIDFD series. No, I don't think FAN_FS_ERROR is quite ready for the coming merge window. So you should be fine. Honza -- Jan Kara SUSE Labs, CR