Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Gabriel Krisman Bertazi <krisman@collabora.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Shreeya Patel <shreeya.patel@collabora.com>,
        linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 04/11] unicode: mark the version field in struct
 unicode_map unsigned
Organization: Collabora
References: <20210818140651.17181-1-hch@lst.de>
        <20210818140651.17181-5-hch@lst.de>
Date:   Mon, 23 Aug 2021 10:54:02 -0400
In-Reply-To: <20210818140651.17181-5-hch@lst.de> (Christoph Hellwig's message
        of "Wed, 18 Aug 2021 16:06:44 +0200")
Message-ID: <87y28s1ab9.fsf@collabora.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Christoph Hellwig <hch@lst.de> writes:

> unicode version tripplets are always unsigned.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>

Thanks,

> ---
>  include/linux/unicode.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/unicode.h b/include/linux/unicode.h
> index 6a392cd9f076..0744f81c4b5f 100644
> --- a/include/linux/unicode.h
> +++ b/include/linux/unicode.h
> @@ -6,7 +6,7 @@
>  #include <linux/dcache.h>
>  
>  struct unicode_map {
> -	int version;
> +	unsigned int version;
>  };
>  
>  int utf8_validate(const struct unicode_map *um, const struct qstr *str);

-- 
Gabriel Krisman Bertazi