Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2177039pxb; Mon, 23 Aug 2021 13:58:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHiLSbqsB1stclFkWpZ5ol5Z3dzXMGd7vIFQ0NlSp3QjKLceg33ZhyddVqlmvyA9gkEd3Y X-Received: by 2002:a05:6402:384:: with SMTP id o4mr40090221edv.128.1629752310251; Mon, 23 Aug 2021 13:58:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629752310; cv=none; d=google.com; s=arc-20160816; b=XK6E8Waw7Uex4cVkPDOP6Mh70EtAQ7CdhVI4OuBMe/nmAy4Hdxt2vlkgxZA3dYBxHe UWMiaEhYn6xskoSChbZTn+cusKXlIvWfD6vp6cpEyjYCidMPjwjkQvmXlfTSFyetc3kG FQ97AFm5yHhBe8+NuWWO6H/IlTV0F8e0im04Ostenmh0Tje7xCMpYFx4OVNol/kEQMea E8/T/n8D+D9RzCTWrCHsjPLZLWlyRMvnIwNIKmodxP8yhDrZQW7AUkqtY5upS0hq+VPT U2mcthidMZ3Hebn1/d8WdJ/obXQ0IPzvDDmqZcPGl7rKUmqVJyNlerTkN1MpCGSKMj/l rXGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=viPh+0UJyTwjrfYxnKuRCjFXOrg8d7O9dPBV2w1jhQo=; b=AXztOKEm+x0KKigbew2bd4JGEO2vfi978s3l/r9+VGs0+yfBEeOcpKmAqr9c9LxPCq 4L490If/siurSI8YaY8l+zA2emaQ6ch/r4HL3RVJduwLLDut5N32NPRNhFcH/JexaxMD 7sXonqm76nZnU9z4ZSIYyCnxQUxhI3EvkVFO9ezEl2zspCyul8f//EKw36nHadGtCB0D NqExPBFi9knpVcb8U98MNoDhmMqu8DTe2iQOVEx+3ZSJWZEwQAefk6608wswNeM+Es0s OpKeumECakvYEb10h4hTStZiJFtsNRd0WQ08E39uA+OCf7TiE0D+2vJrA5rt/CSvvKWN Zl/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=cCYTzhYC; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nb10si6957849ejc.412.2021.08.23.13.58.06; Mon, 23 Aug 2021 13:58:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=cCYTzhYC; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232710AbhHWU6n (ORCPT + 99 others); Mon, 23 Aug 2021 16:58:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232594AbhHWU6m (ORCPT ); Mon, 23 Aug 2021 16:58:42 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC669C061575 for ; Mon, 23 Aug 2021 13:57:59 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id y23so17766636pgi.7 for ; Mon, 23 Aug 2021 13:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=viPh+0UJyTwjrfYxnKuRCjFXOrg8d7O9dPBV2w1jhQo=; b=cCYTzhYCc+5UIWdSxQdJiIdjTBmUrpYexZ+GhELekTQzgUIgY8Dlfd7yL6Ff1yWKSY L+naw0dPpc2gr2+htpd2ZMVtVL6fG9Tag9Q1wCFypTa5ZGyxwB0wERVJtqEt63CM5I1I B2/BGEenOHr/Rq5xjs8wJco0+TEQyhdAs+Gfmq4gMeNTsBZNEsG2MXlT1mkdZRRAduAC q77L00UESyhD7X1PyDfxpaBGhcgkscRLg4DX6W3oRB93x6q+4EXuIszs6+T8iEBSquvY 3SHmYNQGLqoiA3Afhrvk87/PYGSse1LS7/EARSP3v81J0/t2fvKNUnujNzgNxq8HOJZz S1PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=viPh+0UJyTwjrfYxnKuRCjFXOrg8d7O9dPBV2w1jhQo=; b=EDvHuq7/qNhUadkzQ+TVu55JmNsUfP+RVBjf101raAnbiyH4riZ/M2ZV7diC+GD5BD cuTh9im0Ssh+C7tjGDaRF4CMwPLPGyJtLdNJ5+P2kP5/V1PlUy+77KM6WsUBMNPFis+g qkVqtXgCcnALp9NwVef2GJyUSgRsO6GYA/poAUPRRkpajsnt82WXdYDwJLSYcW/qNeE3 F8bk7t/8bbRkTqIk60R3CRtCJqh2YFKybPekfPRdCNZdRRTM8itQjC6AKtrE6YMdvwPJ xyJU7Gw0pG2PVwdWomLzXxupA7kh3S4u1mgITVgGWZUHSNRiVUWL2ZtOHUWkFUIPbNtE cmRA== X-Gm-Message-State: AOAM533U8sE7pGueFcwZ7zxE/KkZa2emHEFJ1UdJy3uduDBlF5IHoEL+ 8ia78GkC8g5DbBF1mZ59d9hDguGSgsX5GS9kVp92jQ== X-Received: by 2002:a05:6a00:9a4:b0:3e2:f6d0:c926 with SMTP id u36-20020a056a0009a400b003e2f6d0c926mr28665609pfg.31.1629752279308; Mon, 23 Aug 2021 13:57:59 -0700 (PDT) MIME-Version: 1.0 References: <20210823123516.969486-1-hch@lst.de> <20210823123516.969486-6-hch@lst.de> In-Reply-To: <20210823123516.969486-6-hch@lst.de> From: Dan Williams Date: Mon, 23 Aug 2021 13:57:48 -0700 Message-ID: Subject: Re: [PATCH 5/9] dax: move the dax_read_lock() locking into dax_supported To: Christoph Hellwig Cc: Vishal Verma , Dave Jiang , Mike Snitzer , Matthew Wilcox , linux-xfs , Linux NVDIMM , linux-fsdevel , linux-ext4 Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Aug 23, 2021 at 5:40 AM Christoph Hellwig wrote: > > Move the dax_read_lock/dax_read_unlock pair from the callers into > dax_supported to make it a little easier to use. Looks good: Reviewed-by: Dan Williams