Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2194901pxb; Mon, 23 Aug 2021 14:24:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTYqqqBsaan69y7ZmmGZGvDU8fGpeRrQbGoufbt+KN01h+tgG6keU0JyDpUhL6VsrEtuF7 X-Received: by 2002:a02:cf34:: with SMTP id s20mr32134443jar.121.1629753882209; Mon, 23 Aug 2021 14:24:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629753882; cv=none; d=google.com; s=arc-20160816; b=lyuk2qBebUWe+OTukktRu+yylzuhgzgMKGFkJH5ecxcNmyODL4PlNwyY/CDjf7ZLCV KwHIvtXTAPBlaoTVYIvFFU347ayhOlX6IDIOSZGLflpRUnTzRgrMcORaW287rgelqM3w NZxhygf11ss/HGhBGWu+8cOySf398LyfQ8Nu0qDiVHISD9H5x4dQMXjYVO06BcU8l6BT Q22NnJgFXl7td/qYl7kmi2mulpvmF43YOG6aP+1Z8uHHtW4c5LkhPdJCVrlQkyYEEoyG WMHKI4gjheMvby4h8ugsD7SQn8EUnJ/6u11dxUROGz7R7D0h2hR9mphEGWdhyCg1CVuF BBuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ShErwyspG88Bo4yVlFpB0fmc1BjfRh8zuGfu0CGRDeA=; b=wh6j9Pcs0vtKsbyZYoASkt1HtT4/bwqyvOGE9xU60KxbzqtOdHO7nKOOzp/a1cwUKD XUWUhDVzg0Ta7Axl2nt6Zt5QY28LEYb6L6Txp8BYBMZt16j47g8XuJnvRj9hY6Xb0Uwn Pc7/JAX7HVLggiHcp783bchP1BdIHgaed0JVZlfDvCceuxhnI3K/5ONcr2syEeojoR+Q fyXoWFnNFmTMdrrUCGV3LeLl+215Jr5LvvFliQyVY+SywPYkeaf/NpPrFCtaW6b7JU44 ljAFLTPmyjB2/HnGQt/S3ad+sX6kMRjwN/HxRYlJ6x0ebDUVon+oAg0WAHGaqFuPHft8 FfIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=rHIKZbBU; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d7si5773337ila.10.2021.08.23.14.24.30; Mon, 23 Aug 2021 14:24:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=rHIKZbBU; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232754AbhHWVXs (ORCPT + 99 others); Mon, 23 Aug 2021 17:23:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232503AbhHWVXs (ORCPT ); Mon, 23 Aug 2021 17:23:48 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9ED1C061575 for ; Mon, 23 Aug 2021 14:23:04 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id j10-20020a17090a94ca00b00181f17b7ef7so374793pjw.2 for ; Mon, 23 Aug 2021 14:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ShErwyspG88Bo4yVlFpB0fmc1BjfRh8zuGfu0CGRDeA=; b=rHIKZbBUCGl81JJDCGO2jSGr728UIVVQ13KxyIxc5kP6Wg5oWA9rRVWif9iIao5pL4 L8JX62XyKt1eePLQ2AwBJuJrwPwVawP5zim6ZdRWmHiKv2kKR3fko7lTmbKjyT/aQtzo MEdxWwqwa1yVZo9MHkLO9AqBKKOAaM2gOsmwCUlHxgSNIJ8uSbFInX867fUxouhXCXBK gKKCWO53t3zw6Z8NYQly+wmZgIqWldfA/074D115o3Qsil+IMBtncqlvsQq8DAEwET7c V12Srx4AvkF0ONhtcsEFOppkKM7yNRBoaPdKFKb4agsQdX7D6hUMAsWrwA5FtIt/Kyou eNlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ShErwyspG88Bo4yVlFpB0fmc1BjfRh8zuGfu0CGRDeA=; b=D6pSKbmVuDXyvJpw9TXDVsf2UYX9g/5aiFOvjPw5F2Z0JIhx4ABW0Vk6TLli22OtCv QbWO8JLKXHlnMyImHH8nElD120uckeM/HiDY3cc7u4yirJMxuzDgKUD7AhVQjthCNH90 ty+tlbSfF1WWD3MKGCVEiBGcLjiK3c5I3WtY3Z8NKFYMadzviDoh63xIxYxMVpWLi6S6 oPthJYMxndxozCVNb3bWW2Z/ZLVb7Kczr5WIN2XhGQXwNFxFCNv+6q516VuoiecLV1HJ h4ZYRKSvVVqtTlSwAR60Od+iWwRAFLygLbR94OSAdbrKCEujjh+CiaOw9o5+xznXvqUY USZg== X-Gm-Message-State: AOAM532sxC8KQN9Q/0lL4NZ9ImMu+QT1J+1JWxBjy7hPJq0DkVSHcYx0 YWUj2kEVzLpqNHPPz0jDYnU5aLQMlr9PAl8joVlDJg== X-Received: by 2002:a17:902:edd0:b0:135:b351:bd5a with SMTP id q16-20020a170902edd000b00135b351bd5amr2141894plk.52.1629753782818; Mon, 23 Aug 2021 14:23:02 -0700 (PDT) MIME-Version: 1.0 References: <20210823123516.969486-1-hch@lst.de> <20210823123516.969486-10-hch@lst.de> In-Reply-To: <20210823123516.969486-10-hch@lst.de> From: Dan Williams Date: Mon, 23 Aug 2021 14:22:52 -0700 Message-ID: Subject: Re: [PATCH 9/9] dax: remove bdev_dax_supported To: Christoph Hellwig Cc: Vishal Verma , Dave Jiang , Mike Snitzer , Matthew Wilcox , linux-xfs , Linux NVDIMM , linux-fsdevel , linux-ext4 Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Aug 23, 2021 at 5:45 AM Christoph Hellwig wrote: > > All callers already have a dax_device obtained from fs_dax_get_by_bdev > at hand, so just pass that to dax_supported() insted of doing another > lookup. Looks good, series passes regression tests: Reviewed-by: Dan Williams I can take this with an XFS ack, or if Darrick wants to carry it to make Ruan's life easier that's ok with me.