Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2474412pxb; Mon, 23 Aug 2021 23:21:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzV7yu38QV4a6v046Kyy/Ijz5Yr/KbQjXQNR4e4PyntJ7akMS2sdJGxP5laquBgQ3ef2/LI X-Received: by 2002:a05:6402:2810:: with SMTP id h16mr12469532ede.133.1629786112378; Mon, 23 Aug 2021 23:21:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629786112; cv=none; d=google.com; s=arc-20160816; b=DmvJl79hGr/d00YKAH/Nh4SCfn8+aDvXRwz9a1fKUE8lTTfRG35orWUWR6AElx+Nq2 VYc3GWznEL3xBpmjDzBVRhX0HBTysIZigmru248a84gWXIZdxUywGvAQg92t7fwr2G/r S4kqBhK/W/8eHbQvRRFStc9VKKMGktsFICx2nh0y44wVWfUeRc7qM4ozutkLwfnyymdb j3jbQI5WAkI+dhkUR+HLd0r8UJJ6Pc4DWvGL2pf7fabarBr8pbNkOFN8p4KMKkZLprAZ dp4+4/6uJmmpiaGkn3x6CB6QKMIjOD+DzGGNrf8srCtvlQIBRXNMiD1BPIlpGglECWy2 VnWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=CXSbZMYiCQoxkzltTxQQRw+UfOox1ZJHqfOgECRkSSs=; b=wbtjs3qx9HQR61RtSwSTutVaVxLbeKDw+L9pj3AXwp1faAVEQP+QlSf1TNXYNTTA6Z WOOjd9Y0ZEOc9U5GT8rq/aZUNQXR0HI/P/qG1K6yIekf+B5MgvVY13XQoM+/t7NqZ/pZ ayzT3YbfpeZstNh5EsZKegB7MMTjKI39EBxqdev14im+Om05cpPcpnS5bpX1S7MPireb qhrHCLoNKU3TaPKI/XNhgxaM6UIcAMuXWOSrgQ5nj/EfbMWw0xlJaqeDJEXPCHIs2s6j gX19MwLs/FoClBB81GyOJKS4MaAa61Jsymv5Vcw6u4vh6R9NSo4IuY9UyV2dTZocvJDV T/kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qL0cPbHZ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m20si15983239edc.375.2021.08.23.23.21.22; Mon, 23 Aug 2021 23:21:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qL0cPbHZ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230441AbhHXGVy (ORCPT + 99 others); Tue, 24 Aug 2021 02:21:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:37896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232320AbhHXGVs (ORCPT ); Tue, 24 Aug 2021 02:21:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CCE6861027; Tue, 24 Aug 2021 06:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629786063; bh=bL+8jiRZvadmenfA31Udhy/TMRIUStlfq31nSmr/TQE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=qL0cPbHZeqU1SyWmVUnYHj/kL8KHMQlf8rafFgih3hQg5bl9vuWMHnAfyD/JK7Bmp xfzQDveTkstSjfNBzKAkMicLI7X6IrP3qHyltCzkKh51w+pOUoP7CwObhP28ZOmE39 /KH2kAKU/MecL2dEejhjKhD60v/nA8CXyBhNQob/iWqf2l9XoeIjICCts1O76Z1awH H+FOQV8+8BCDvsnkkW3tK6c5lxOxqNJp+vBdAGbT0RhGabJGdSD2OyBJQJuInuqNW7 mMXp7yofmJ/JC9Wx/kMoNPWP1q7gIFrYJpJbPEzjeopN2VAhV7CoT1ErNgGoCsWxh2 I5+6CyIErkX9Q== Subject: Re: [f2fs-dev] [PATCH 02/11] f2fs: simplify f2fs_sb_read_encoding To: Christoph Hellwig , Gabriel Krisman Bertazi Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Shreeya Patel , linux-f2fs-devel@lists.sourceforge.net References: <20210818140651.17181-1-hch@lst.de> <20210818140651.17181-3-hch@lst.de> From: Chao Yu Message-ID: <1fb2db25-289b-36d5-a72e-091d7282726c@kernel.org> Date: Tue, 24 Aug 2021 14:21:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210818140651.17181-3-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 2021/8/18 22:06, Christoph Hellwig wrote: > Return the encoding table as the return value instead of as an argument, > and don't bother with the encoding flags as the caller can handle that > trivially. > > Signed-off-by: Christoph Hellwig Reviewed-by: Chao Yu Thanks,